Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gettext] Remove SUBPATH, add iconv linking info #20090

Merged
merged 6 commits into from
Sep 16, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 10, 2021

@JackBoosY JackBoosY self-assigned this Sep 10, 2021
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 10, 2021
@JackBoosY JackBoosY mentioned this pull request Sep 10, 2021
3 tasks
@JonLiu1993 JonLiu1993 mentioned this pull request Sep 10, 2021
2 tasks
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wrobelda
Copy link
Contributor

wrobelda commented Sep 15, 2021

@dg0yt can you also remove the libiconv patch from kf5i18n? It would test this PR nicely, given that many other kf5 ports depend on libiconv in kf5i18n, see e.g. #19195 (comment) or #19766 (comment).

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dg0yt
Copy link
Contributor Author

dg0yt commented Sep 16, 2021

@dg0yt can you also remove the libiconv patch from kf5i18n? It would test this PR nicely, given that many other kf5 ports depend on libiconv in kf5i18n, see e.g. #19195 (comment) or #19766 (comment).

@wrobelda I have to revert the related change. The issue is that kf5i18n doesn't use the wrapped FindIntl.cmake but maintains its own FindLibIntl.cmake.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 16, 2021
@BillyONeal BillyONeal merged commit fbe0784 into microsoft:master Sep 16, 2021
@BillyONeal
Copy link
Member

Thanks for the bugfix!

@dg0yt dg0yt deleted the gettext-make branch September 17, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants