[kf5declarative] new port #19813

wrobelda · 2021-08-31T02:12:05Z

Describe the pull request
Adds new port. Depends on:

[kf5kio] new port #19779
[kf5package] new port #19195
[kf5notifications] new port #19828
[libcanberra] Linux static .pc fix & other improvements #20782
Which triplets are supported/not supported? Have you updated the CI baseline?

All official, plus arm64-osx
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: bce20c3b942e4f4403efcb239c0058955ac0c5dd
-- New SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a761a22de8a5b82503837e58630f9aec38f05d52 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index cc146fd..166ad96 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2964,6 +2964,10 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
+    "kf5notifications": {
+      "baseline": "5.75.0",
+      "port-version": 0
+    },
     "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: bce20c3b942e4f4403efcb239c0058955ac0c5dd
-- New SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: bce20c3b942e4f4403efcb239c0058955ac0c5dd
-- New SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5globalaccel": {
+    "kf5declarative": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5declarative": {
+    "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2960,7 +2960,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5package": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2968,7 +2968,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5globalaccel": {
+    "kf5declarative": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5declarative": {
+    "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2960,7 +2960,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5package": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2968,7 +2968,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5globalaccel": {
+    "kf5declarative": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5declarative": {
+    "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2960,7 +2960,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5package": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2968,7 +2968,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5globalaccel": {
+    "kf5declarative": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5declarative": {
+    "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2960,7 +2960,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5package": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2968,7 +2968,7 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 10f578b..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5globalaccel": {
+    "kf5declarative": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5declarative": {
+    "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 0
     },
@@ -2960,15 +2960,15 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5package": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5notifications": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5notifications": {
+    "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5bc27e8a5073ba139e29432a1b0d8ced50794a41 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index fd3a461..3eb38c8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2932,7 +2932,6 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-
     "kf5guiaddons": {
       "baseline": "5.84.0",
       "port-version": 2

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5bc27e8a5073ba139e29432a1b0d8ced50794a41 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index e1a3e04..feb5be0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2932,7 +2932,6 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-
     "kf5guiaddons": {
       "baseline": "5.84.0",
       "port-version": 2
@@ -2972,7 +2971,7 @@
     "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5plotting": {
       "baseline": "5.84.0",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 783aad3..39de514 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2992,7 +2992,6 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    },
     "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 0
@@ -3025,11 +3024,11 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5notifications": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5notifications": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f30b096..39de514 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3024,11 +3024,11 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5notifications": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5notifications": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- New SHA: dc898926b69ad5ef32655c80d3cc2acdf47d166f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/kf5bookmarks/portfile.cmake
ports/kf5declarative/portfile.cmake
ports/kf5kio/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/kf5xmlgui/portfile.cmake
ports/libcanberra/portfile.cmake

Co-authored-by: NancyLi1013 <[email protected]>

wrobelda · 2021-10-20T22:47:32Z

@NancyLi1013 no longer has dependencies, ready to be merged.

ports/kf5declarative/vcpkg.json

NancyLi1013 · 2021-10-22T07:37:53Z

LGTM now, thanks for adding this new port. @wrobelda

github-actions bot approved these changes Aug 31, 2021

View reviewed changes

wrobelda force-pushed the kf5declarative branch from c704bcf to 4cae7ae Compare August 31, 2021 02:20

github-actions bot approved these changes Aug 31, 2021

View reviewed changes

github-actions bot requested changes Aug 31, 2021

View reviewed changes

wrobelda force-pushed the kf5declarative branch 2 times, most recently from 841f509 to 3469eff Compare August 31, 2021 02:36

github-actions bot requested changes Aug 31, 2021

View reviewed changes

github-actions bot approved these changes Aug 31, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Aug 31, 2021

NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Aug 31, 2021

wrobelda force-pushed the kf5declarative branch from 3469eff to be976f9 Compare August 31, 2021 16:33

github-actions bot requested changes Aug 31, 2021

View reviewed changes

wrobelda force-pushed the kf5declarative branch from b31a998 to 4df84b0 Compare August 31, 2021 18:37

github-actions bot requested changes Aug 31, 2021

View reviewed changes

wrobelda force-pushed the kf5declarative branch from 4df84b0 to d116cb2 Compare September 1, 2021 10:37

github-actions bot requested changes Sep 1, 2021

View reviewed changes

wrobelda force-pushed the kf5declarative branch from 9b87255 to 8a094fe Compare September 16, 2021 11:10

github-actions bot requested changes Sep 16, 2021

View reviewed changes

wrobelda force-pushed the kf5declarative branch from 8a094fe to ad61150 Compare September 16, 2021 11:17

github-actions bot requested changes Sep 16, 2021

View reviewed changes

This was referenced Sep 16, 2021

[kf5kcmutils] new port #20199

Merged

[ECM] fix FindCanberra for static builds #20213

Merged

wrobelda force-pushed the kf5declarative branch from ad61150 to dfc1187 Compare September 16, 2021 22:33

github-actions bot requested changes Sep 16, 2021

View reviewed changes

wrobelda and others added 19 commits October 21, 2021 00:47

[kf5declarative] update versions

58f2506

[kf5declarative] fix tool handling on macOS

ddadf3c

[kf5declarative] fix cmake config for static builds

ba4bff0

[kf5declarative] update versions

78e3659

[kf5declarative] AUTO_CLEAN tools

d19f1b6

[kf5declarative] update versions

5cc1b28

[kf5declarative] explicitly control epoxy feature

d513e83

[kf5declarative] KDE_INSTALL_QMLDIR instead moving by hand

345c2c9

[kf5declarative] update versions

7989843

[kf5declarative] minimize patch size

71d83a4

Co-authored-by: NancyLi1013 <[email protected]>

[kf5declarative] fix indentation

92842aa

Co-authored-by: NancyLi1013 <[email protected]>

[kf5declarative] drop semVer versioning

c6d99a7

Co-authored-by: NancyLi1013 <[email protected]>

[kf5declarative] enable parallel builds

47605eb

[kf5declarative] update versions

390f61e

[kf5declarative] mark CMAKE_DISABLE_FIND_PACKAGE_EPOXY as maybe unused

4fe5a99

[kf5declarative] update versions

9427105

[kf5declarative] formatting

a40b638

Co-authored-by: NancyLi1013 <[email protected]>

[kf5declarative] mark BUNDLE_INSTALL_DIR as maybe unused

fe557ed

[kf5declarative] update versions

ea0a554

wrobelda force-pushed the kf5declarative branch from 32fd57e to ea0a554 Compare October 20, 2021 22:47

github-actions bot approved these changes Oct 20, 2021

View reviewed changes

NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 21, 2021

NancyLi1013 reviewed Oct 21, 2021

View reviewed changes

ports/kf5declarative/vcpkg.json Show resolved Hide resolved

NancyLi1013 approved these changes Oct 22, 2021

View reviewed changes

NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 22, 2021

vicroms merged commit a3aef4e into microsoft:master Oct 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kf5declarative] new port #19813

[kf5declarative] new port #19813

wrobelda commented Aug 31, 2021 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

wrobelda commented Oct 20, 2021

NancyLi1013 commented Oct 22, 2021

[kf5declarative] new port #19813

[kf5declarative] new port #19813

Conversation

wrobelda commented Aug 31, 2021 • edited Loading

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

wrobelda commented Oct 20, 2021

NancyLi1013 commented Oct 22, 2021

wrobelda commented Aug 31, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?