[libcanberra] Linux static .pc fix & other improvements #20782

wrobelda · 2021-10-16T10:24:37Z

Describe the pull request

What does your PR fix?
- Fixes an issue with a missing lltdl dependency in .pc on Linux
- incorporates Debian patches
- featurizes all of the backends and establishes sane defaults for both platforms supported
  - macOS has "null" backend only since pulseaudio port is not available in vcpkg, the gstreamer currently doesn't build on macOS, while all other backends are irrelevant
Which triplets are supported/not supported? Have you updated the CI baseline?

No change
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: da899d8dca6ef08e2945cd909475d7ef93672111
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index c1f0db1..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "da899d8dca6ef08e2945cd909475d7ef93672111",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: 293c17437120d7fd1f32a88143cfbb7f7d996809
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index dafc703..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "293c17437120d7fd1f32a88143cfbb7f7d996809",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: 6a624035d9bfcfdb0616e71e363f87d2e722505f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index dafc703..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "293c17437120d7fd1f32a88143cfbb7f7d996809",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: 7d85f55e8fee36aa93aa13b845a01f46ffea4821
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index 0e50e52..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "7d85f55e8fee36aa93aa13b845a01f46ffea4821",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: 1c5fea1a08912df092114c52123100925de52c78
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index 6598ec8..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1c5fea1a08912df092114c52123100925de52c78",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: 0296c7dea8c76c2c18f08d0ac6c595cfdd87bd02
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index dbbed6b..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "0296c7dea8c76c2c18f08d0ac6c595cfdd87bd02",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: 9332e8b3945451a2776337d41c54c7200d187a28
-- New SHA: c68c1c2f72da0e0014a633c04a5fd242aa17eabd
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index 4927440..8a3cc52 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "c68c1c2f72da0e0014a633c04a5fd242aa17eabd",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c1bd850c629977b98b71bd7a6ab6b7949a5f07e6 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libcanberra.json b/versions/l-/libcanberra.json
index 73b7604..6a3eb68 100644
--- a/versions/l-/libcanberra.json
+++ b/versions/l-/libcanberra.json
@@ -6,7 +6,7 @@
       "port-version": 1
     },
     {
-      "git-tree": "c68c1c2f72da0e0014a633c04a5fd242aa17eabd",
+      "git-tree": "9332e8b3945451a2776337d41c54c7200d187a28",
       "version": "0.30",
       "port-version": 0
     }

wrobelda · 2021-10-18T12:23:55Z

@PhoebeHui I tested all the features except gstreamer, which currently fails to build, as reported in #20785. Should be fixed by #20814

PhoebeHui · 2021-10-19T06:39:28Z

@wrobelda, thanks for testing these features! I don't want to block this PR, since it's in draft and 'gstreamer' is not a default feature, we can retest this feature after the PR merged.

ports/libcanberra/portfile.cmake

wrobelda marked this pull request as draft October 16, 2021 10:24

github-actions bot requested changes Oct 16, 2021

View reviewed changes

wrobelda changed the title ~~[libcanberra] Linux static fixes [WIP]~~ [libcanberra] Linux static fixes & other [WIP] Oct 16, 2021

github-actions bot requested changes Oct 16, 2021

View reviewed changes

wrobelda force-pushed the libcanberra_fixes branch from d3b8b7a to f620d83 Compare October 16, 2021 10:45

github-actions bot requested changes Oct 16, 2021

View reviewed changes

wrobelda force-pushed the libcanberra_fixes branch from f620d83 to eda6130 Compare October 16, 2021 10:49

github-actions bot requested changes Oct 16, 2021

View reviewed changes

wrobelda mentioned this pull request Oct 16, 2021

[kf5declarative] new port #19813

Merged

4 tasks

wrobelda force-pushed the libcanberra_fixes branch from eda6130 to fa429ed Compare October 16, 2021 11:36

github-actions bot requested changes Oct 16, 2021

View reviewed changes

[libcanberra] fix Linux static consumption

5f96773

wrobelda force-pushed the libcanberra_fixes branch from fa429ed to 7138d20 Compare October 16, 2021 11:38

github-actions bot requested changes Oct 16, 2021

View reviewed changes

wrobelda changed the title ~~[libcanberra] Linux static fixes & other [WIP]~~ [libcanberra] Linux static fixes & other improvements Oct 16, 2021

wrobelda marked this pull request as ready for review October 16, 2021 12:03

wrobelda changed the title ~~[libcanberra] Linux static fixes & other improvements~~ [libcanberra] Linux static fixe & other improvements Oct 16, 2021

wrobelda changed the title ~~[libcanberra] Linux static fixe & other improvements~~ [libcanberra] Linux static .pc fix & other improvements Oct 16, 2021

github-actions bot requested changes Oct 16, 2021

View reviewed changes

wrobelda added 4 commits October 16, 2021 14:33

[libcanberra] add Debian patches

0c8d18f

[libcanberra] make all backends features

dfb8450

[libcanberra] bump port version

6c1ae7b

[libcanberra] update versions

35ca978

wrobelda force-pushed the libcanberra_fixes branch from e1acaf7 to 35ca978 Compare October 16, 2021 12:33

github-actions bot approved these changes Oct 16, 2021

View reviewed changes

NancyLi1013 assigned PhoebeHui Oct 18, 2021

PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Oct 18, 2021

PhoebeHui approved these changes Oct 19, 2021

View reviewed changes

PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 19, 2021

BillyONeal reviewed Oct 20, 2021

View reviewed changes

ports/libcanberra/portfile.cmake Show resolved Hide resolved

vicroms removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 20, 2021

vicroms merged commit 30b217b into microsoft:master Oct 20, 2021

wrobelda deleted the libcanberra_fixes branch October 20, 2021 22:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libcanberra] Linux static .pc fix & other improvements #20782

[libcanberra] Linux static .pc fix & other improvements #20782

wrobelda commented Oct 16, 2021 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

wrobelda commented Oct 18, 2021 •

edited

Loading

PhoebeHui commented Oct 19, 2021

[libcanberra] Linux static .pc fix & other improvements #20782

[libcanberra] Linux static .pc fix & other improvements #20782

Conversation

wrobelda commented Oct 16, 2021 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

wrobelda commented Oct 18, 2021 • edited Loading

PhoebeHui commented Oct 19, 2021

wrobelda commented Oct 16, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

wrobelda commented Oct 18, 2021 •

edited

Loading