Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 no absolute paths #21144

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

autoantwort
Copy link
Contributor

For #20469

The changed file is used by the sysconfig module.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 85b31152df8da18be5ec2b0dbd7b39b0d2404db4 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 14d5b96..4fa170a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5402,7 +5402,7 @@
     },
     "python3": {
       "baseline": "3.10.0",
-      "port-version": 0
+      "port-version": 1
     },
     "qca": {
       "baseline": "2.3.1",

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Nov 4, 2021
@JackBoosY
Copy link
Contributor

There are many issues with python3 in vcpkg, I hope we can solve them step by step.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 4, 2021
@Hoikas
Copy link
Contributor

Hoikas commented Nov 4, 2021

@JackBoosY what issues does python3 have aside from this one?

@JackBoosY
Copy link
Contributor

@Hoikas #16956 #16311

@Hoikas
Copy link
Contributor

Hoikas commented Nov 5, 2021

#16956 is a port bug with pybind11 that happens even without vcpkg, IME. I've never been able to repro #16311 😢

@dan-shaw dan-shaw merged commit d9b47f3 into microsoft:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants