-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python2] no absolute paths #22329
Merged
Merged
[python2] no absolute paths #22329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:port-bug
The issue is with a library, which is something the port should already support
label
Jan 4, 2022
JackBoosY
approved these changes
Jan 4, 2022
strega-nil-ms
suggested changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the changes in a local branch, so I'll push.
JackBoosY
added
requires:author-response
and removed
info:reviewed
Pull Request changes follow basic guidelines
labels
Jan 5, 2022
@autoantwort what do you think of my changes? |
autoantwort
commented
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM!
autoantwort
force-pushed
the
python2-no-absolute
branch
from
February 24, 2022 02:45
1a27b46
to
ed81b05
Compare
I will ping Nicole internal. |
strega-nil-ms
approved these changes
Feb 24, 2022
ekilmer
added a commit
to ekilmer/vcpkg
that referenced
this pull request
Mar 2, 2022
* master: (108 commits) [calceph] update to version 3.5.1 (microsoft#23325) [SpeexDSP] Missing windows definitions (microsoft#23296) [triton] Fix usage (microsoft#23250) [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567) [openmvg] no absolute paths (microsoft#22342) [python2] no absolute paths (microsoft#22329) [libcpplocate] New port (microsoft#23173) [Intelrdfpmathlib] Fix post build error (microsoft#23286) [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321) [new-port-template] Remove deprecated cmake (microsoft#23283) [xtensor] Update to 0.24.0 (microsoft#23238) [pcl/soil2] Disable optimizations for individual function (microsoft#23252) [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258) [nanobench] Update to 4.3.6 (microsoft#23262) [elfio] Update elfio to 3.10 (microsoft#23263) [tomlplusplus] Update to 3.0.1 (microsoft#23268) [shaderc] Fix CMake export target files (microsoft#23269) [PCL] Fix namespace and VS2022 error C3052 (microsoft#23273) [libressl] update to 3.4.2 (microsoft#23276) [asio-grpc] Update to 1.4.0 (microsoft#23277) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #20469
Like #21144