Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python2] no absolute paths #22329

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

autoantwort
Copy link
Contributor

For #20469

Like #21144

@JackBoosY JackBoosY self-assigned this Jan 4, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 4, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 4, 2022
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes in a local branch, so I'll push.

ports/python2/portfile.cmake Outdated Show resolved Hide resolved
ports/python2/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 5, 2022
@strega-nil-ms
Copy link
Contributor

@autoantwort what do you think of my changes?

Copy link
Contributor Author

@autoantwort autoantwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

ports/python2/portfile.cmake Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

I will ping Nicole internal.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 25, 2022
@vicroms vicroms merged commit a46f923 into microsoft:master Mar 2, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 2, 2022
* master: (108 commits)
  [calceph] update to version 3.5.1 (microsoft#23325)
  [SpeexDSP] Missing windows definitions (microsoft#23296)
  [triton] Fix usage (microsoft#23250)
  [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567)
  [openmvg] no absolute paths (microsoft#22342)
  [python2] no absolute paths (microsoft#22329)
  [libcpplocate] New port (microsoft#23173)
  [Intelrdfpmathlib] Fix post build error (microsoft#23286)
  [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321)
  [new-port-template] Remove deprecated cmake (microsoft#23283)
  [xtensor] Update to 0.24.0 (microsoft#23238)
  [pcl/soil2] Disable optimizations for individual function (microsoft#23252)
  [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258)
  [nanobench] Update to 4.3.6 (microsoft#23262)
  [elfio] Update elfio to 3.10 (microsoft#23263)
  [tomlplusplus] Update to 3.0.1 (microsoft#23268)
  [shaderc] Fix CMake export target files (microsoft#23269)
  [PCL] Fix namespace and  VS2022 error C3052 (microsoft#23273)
  [libressl] update to 3.4.2 (microsoft#23276)
  [asio-grpc] Update to 1.4.0 (microsoft#23277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants