[ceres] Don't force C++14 on downstream customers. #22983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves microsoft#22980 microsoft#12785 Added a set of `CMAKE_CXX_STANDARD` in this CMake config which accidentally overwrites higher versions. Upstream already has a `target_compile_options` to do this the Right Way. This change: * Deletes the offending attempt to set CMAKE_CXX_STANDARD. Downstream users that don't listen to the INTERFACE_COMPILE_FEATURES need to be patched locally. * Modernizes to use vcpkg_cmake_Xxx. * Removes attempt to fix up paths that already appears handled by `vcpkg_cmake_config_fixup`. * Adds quotes.
BillyONeal
added
category:port-bug
|
/cc @cenit |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/ceres/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
cenit
approved these changes
Feb 7, 2022
LilyWangLL
approved these changes
Feb 8, 2022
BillyONeal
added
depends:different-pr
|
Depends on #22984 |
BillyONeal
removed
the
depends:different-pr
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/ceres/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22980
#12785 Added a set of
CMAKE_CXX_STANDARDin this CMake config which accidentally overwrites higher versions. Upstream already has atarget_compile_optionsto do this the Right Way.This change:
vcpkg_cmake_config_fixup.