Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ceres] Don't force C++14 on downstream customers. #22983

Merged
merged 2 commits into from
Feb 9, 2022
Merged

[ceres] Don't force C++14 on downstream customers. #22983

merged 2 commits into from
Feb 9, 2022

Commits on Feb 7, 2022

  1. [ceres] Don't force C++14 on downstream customers. 

    Resolves microsoft#22980

microsoft#12785 Added a set of `CMAKE_CXX_STANDARD` in this CMake config which accidentally overwrites higher versions. Upstream already has a `target_compile_options` to do this the Right Way.

This change:
* Deletes the offending attempt to set CMAKE_CXX_STANDARD. Downstream users that don't listen to the INTERFACE_COMPILE_FEATURES need to be patched locally.
* Modernizes to use vcpkg_cmake_Xxx.
* Removes attempt to fix up paths that already appears handled by `vcpkg_cmake_config_fixup`.
* Adds quotes.
    @BillyONeal
    BillyONeal committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    de99af7 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Merge remote-tracking branch 'origin/master' into HEAD

    @BillyONeal
    BillyONeal committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    37402a6 View commit details
    Browse the repository at this point in the history