Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baseline] Remove rabit from ci.baseline.txt #27649

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Nov 4, 2022

Describe the pull request

  • What does your PR fix?

This record was added by PR: #9203 of ras0219-msft

The issue of port rabit failing to build on osx has been resolved upstream discussions: dmlc/xgboost#5995.

But rabit's dependency dmlc failed to build on osx, so rabit could not build on osx.

Now the problem that dmlc fails to build on osx has been resolved by PR #27495. This caused rabit to start being built on osx. So, this regression is triggered

So we remove the records of rabit from ci.baseline.txt to fix this regression.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 4, 2022
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Nov 4, 2022
@BillyONeal BillyONeal merged commit 7bc4083 into microsoft:master Nov 4, 2022
@BillyONeal
Copy link
Member

Thanks for figuring out the history!

@FrankXie05 FrankXie05 deleted the dev/Frank/baseline_80366 branch November 7, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants