Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Check in baseline results for CI builds #9203

Merged
merged 8 commits into from
Dec 6, 2019

Conversation

ras0219-msft
Copy link
Contributor

No description provided.

@ras0219-msft ras0219-msft added the info:internal This PR or Issue was filed by the vcpkg team. label Dec 3, 2019
@ras0219-msft ras0219-msft self-assigned this Dec 3, 2019
@@ -0,0 +1,1756 @@
###########################################################################
## This file defines the current expected state the ports in the CI system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state the ports -> state of the ports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +65 to +71
# Conflicts with qt5-base and ms-angle
angle:arm64-windows = skip
angle:arm-uwp = skip
angle:x64-uwp = skip
angle:x64-windows = skip
angle:x64-windows-static = skip
angle:x86-windows = skip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflict with qt5-base could be solved by passing -no-angle to qt's configure command but CI will lose qt5's static build unless angle is allowed to be build as a static library (or we introduce extraordinary exceptions concerning dynamic libraries in static builds for some ports)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, if qt5 is currently building angle statically, then that would imply that there's no reason we shouldn't build the separate angle port statically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No qt5 is just deleting the dll's in a static build since on windows the default opengl option is
-opengl dynamic as such the angle dlls are not required since Qt will dynamically load whatever it finds.
Maybe we should simply try static builds with -no-angle on windows and observe what happens.

Comment on lines +1043 to +1051
#Conflicts with angle and qt-5base
ms-angle:arm64-windows = skip
ms-angle:arm-uwp = skip
ms-angle:x64-linux = fail
ms-angle:x64-osx = fail
ms-angle:x64-uwp = skip
ms-angle:x64-windows = skip
ms-angle:x64-windows-static = skip
ms-angle:x86-windows = skip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I tried to build this on windows it failed. I didn't bother to look at it since development seemed to have been suspended. (Maybe we should just remove this one?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, this fork specifically enables uwp.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to transform it into an angle patchset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be possible, but if you're suggesting to apply it onto the moving target of angle upstream, we'd need someone who's actively maintaining that patch over time; I don't know who that would be.

@ras0219-msft ras0219-msft merged commit 92dc30f into microsoft:master Dec 6, 2019
sthagen added a commit to sthagen/microsoft-vcpkg that referenced this pull request Dec 6, 2019
[vcpkg] Check in baseline results for CI builds (microsoft#9203)
Comment on lines +1702 to +1703
vectorclass:arm64-windows=fail
vectorclass:arm-uwp=fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be skipped since vectorclass uses x86_x64 intrinsics and will never build on arm

vicroms pushed a commit that referenced this pull request Jun 8, 2024
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=103701&view=results.

Added `clockutils:x64-linux=fail` to `ci.baseline.txt` by #9203, which
has been fixed by #38834.
```
PASSING, REMOVE FROM FAIL LIST: clockutils:x64-linux
```

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~~SHA512s are updated for each updated download.~~
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version.~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

Co-authored-by: Monica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants