-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Check in baseline results for CI builds #9203
[vcpkg] Check in baseline results for CI builds #9203
Conversation
scripts/ci.baseline.txt
Outdated
@@ -0,0 +1,1756 @@ | |||
########################################################################### | |||
## This file defines the current expected state the ports in the CI system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state the ports -> state of the ports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
# Conflicts with qt5-base and ms-angle | ||
angle:arm64-windows = skip | ||
angle:arm-uwp = skip | ||
angle:x64-uwp = skip | ||
angle:x64-windows = skip | ||
angle:x64-windows-static = skip | ||
angle:x86-windows = skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conflict with qt5-base could be solved by passing -no-angle to qt's configure command but CI will lose qt5's static build unless angle is allowed to be build as a static library (or we introduce extraordinary exceptions concerning dynamic libraries in static builds for some ports)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, if qt5 is currently building angle statically, then that would imply that there's no reason we shouldn't build the separate angle port statically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No qt5 is just deleting the dll's in a static build since on windows the default opengl option is
-opengl dynamic
as such the angle dlls are not required since Qt will dynamically load whatever it finds.
Maybe we should simply try static builds with -no-angle on windows and observe what happens.
#Conflicts with angle and qt-5base | ||
ms-angle:arm64-windows = skip | ||
ms-angle:arm-uwp = skip | ||
ms-angle:x64-linux = fail | ||
ms-angle:x64-osx = fail | ||
ms-angle:x64-uwp = skip | ||
ms-angle:x64-windows = skip | ||
ms-angle:x64-windows-static = skip | ||
ms-angle:x86-windows = skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I tried to build this on windows it failed. I didn't bother to look at it since development seemed to have been suspended. (Maybe we should just remove this one?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall correctly, this fork specifically enables uwp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to transform it into an angle patchset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be possible, but if you're suggesting to apply it onto the moving target of angle upstream, we'd need someone who's actively maintaining that patch over time; I don't know who that would be.
[vcpkg] Check in baseline results for CI builds (microsoft#9203)
vectorclass:arm64-windows=fail | ||
vectorclass:arm-uwp=fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be skipped since vectorclass uses x86_x64 intrinsics and will never build on arm
Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=103701&view=results. Added `clockutils:x64-linux=fail` to `ci.baseline.txt` by #9203, which has been fixed by #38834. ``` PASSING, REMOVE FROM FAIL LIST: clockutils:x64-linux ``` - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~~SHA512s are updated for each updated download.~~ - [ ] ~~The "supports" clause reflects platforms that may be fixed by this new version.~~ - [ ] ~~Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.~~ - [ ] ~~Any patches that are no longer applied are deleted from the port's directory.~~ - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. Co-authored-by: Monica <[email protected]>
No description provided.