Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencolorio] Fix minizip-ng related errors #33335

Merged
merged 18 commits into from
Aug 25, 2023
Merged

[opencolorio] Fix minizip-ng related errors #33335

merged 18 commits into from
Aug 25, 2023

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Aug 23, 2023

Fixes #33314

/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/opencolorio/src/v2.2.1-4d03a7cab0.clean/src/apps/ocioarchive/main.cpp:238:9: error: no matching function for call to 'mz_zip_reader_create'
        mz_zip_reader_create(&reader);

1.Use upstream PR 1806 to fix mz_zip_reader_create() parameter error.
2.Fix minizip-ng can't find zstd.

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static
x64-osx

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static
x64-osx
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 23, 2023
@jimwang118 jimwang118 marked this pull request as ready for review August 24, 2023 02:22
Cheney-W
Cheney-W previously approved these changes Aug 24, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Aug 24, 2023
@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Aug 24, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Aug 25, 2023
@dan-shaw dan-shaw merged commit 42cc786 into microsoft:master Aug 25, 2023
15 checks passed
@jimwang118 jimwang118 deleted the fix_opencolorio branch August 30, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opencolorio] Build failure
4 participants