Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fast-double-parser] Add the Fast Double Parser port #39421

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

dsmith111
Copy link
Contributor

@dsmith111 dsmith111 commented Jun 21, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@dsmith111 dsmith111 changed the title [fast_double_parser] Add the Fast Double Parser port [fast-double-parser] Add the Fast Double Parser port Jun 21, 2024
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 21, 2024
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

fast-double-parser is header-only and can be used from CMake via:

  find_path(FAST_DOUBLE_PARSER_INCLUDE_DIRS "fast_double_parser.h")
  target_include_directories(main PRIVATE ${FAST_DOUBLE_PARSER_INCLUDE_DIRS})

@dsmith111 dsmith111 marked this pull request as ready for review June 21, 2024 06:27
@@ -0,0 +1,7 @@
{
"name": "fast-double-parser",
"version": "0.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: 0.7.0 was released in 2022, why not just update to 0.8.0, which is the lastest version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the mentioned PR. I was asked to devendor the lightgbm port. The LightGBM package is pinned to this version of fast double parser. But, when the LightGBM library is updated to use the v0.8.0 fast double parser library. I'll of course have to update the version here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jun 21, 2024
@BillyONeal BillyONeal merged commit d21e70b into microsoft:master Jun 21, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks!

@dsmith111 dsmith111 deleted the smithdavi/fast_double_parser branch June 21, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants