-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fast-double-parser] Add the Fast Double Parser port #39421
[fast-double-parser] Add the Fast Double Parser port #39421
Conversation
The usage test passed on
|
@@ -0,0 +1,7 @@ | |||
{ | |||
"name": "fast-double-parser", | |||
"version": "0.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question: 0.7.0 was released in 2022, why not just update to 0.8.0, which is the lastest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the mentioned PR. I was asked to devendor the lightgbm port. The LightGBM package is pinned to this version of fast double parser. But, when the LightGBM library is updated to use the v0.8.0 fast double parser library. I'll of course have to update the version here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.