Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fast-double-parser] Add the Fast Double Parser port #39421

Merged
merged 9 commits into from
Jun 21, 2024
Merged

[fast-double-parser] Add the Fast Double Parser port #39421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4f35f8
Fast double port
dsmith111 Jun 21, 2024
6663cf2
Clean up comments
dsmith111 Jun 21, 2024
327e1e9
Version database
dsmith111 Jun 21, 2024
f2387e5
Fix naming; Remove usage
dsmith111 Jun 21, 2024
41ebc8c
Version database
dsmith111 Jun 21, 2024
92cb362
Add white-space
dsmith111 Jun 21, 2024
c931e1e
Version database
dsmith111 Jun 21, 2024
34b6e9f
Remove redundant dependencies/commands
dsmith111 Jun 21, 2024
4a4c756
Version database
dsmith111 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ports/fast-double-parser/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO lemire/fast_double_parser
REF "v${VERSION}"
SHA512 14a23b9e2ddc924d66f2748134364c546c6511ad380fbf59313c1d77c14dc4b0d22367a44b423f835ff2941f8d9c511f18b97ce25eda826ddc08a8eaaf7014bd
HEAD_REF master
)

set(VCPKG_BUILD_TYPE release) # header-only port

file(INSTALL "${SOURCE_PATH}/include/" DESTINATION "${CURRENT_PACKAGES_DIR}/include")

vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
7 changes: 7 additions & 0 deletions ports/fast-double-parser/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "fast-double-parser",
"version": "0.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: 0.7.0 was released in 2022, why not just update to 0.8.0, which is the lastest version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the mentioned PR. I was asked to devendor the lightgbm port. The LightGBM package is pinned to this version of fast double parser. But, when the LightGBM library is updated to use the v0.8.0 fast double parser library. I'll of course have to update the version here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ubiquity:

#39395 (comment)

https://github.com/microsoft/LightGBM/tree/master/external_libs

"description": "Fast function to parse strings into double (binary64) floating-point values, enforces the RFC 7159 (JSON standard) grammar: 4x faster than strtod",
"homepage": "https://github.com/lemire/fast_double_parser",
"license": "Apache-2.0"
}
4 changes: 4 additions & 0 deletions versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2616,6 +2616,10 @@
"baseline": "2021-01-03",
"port-version": 2
},
"fast-double-parser": {
"baseline": "0.7.0",
"port-version": 0
},
"fast-float": {
"baseline": "6.1.1",
"port-version": 0
Expand Down
9 changes: 9 additions & 0 deletions versions/f-/fast-double-parser.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"versions": [
{
"git-tree": "fac99fe686dd7874d02be06d78f4df1a6ac7358d",
"version": "0.7.0",
"port-version": 0
}
]
}