Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow killing Dapr applications #81

Closed
philliphoff opened this issue Mar 23, 2020 · 1 comment
Closed

Allow killing Dapr applications #81

philliphoff opened this issue Mar 23, 2020 · 1 comment
Labels
feature New feature investigate Issues that require investigation P2 Moderate priority
Milestone
0.5.0

Comments

@philliphoff
Copy link
Collaborator

Add an option to kill a running Dapr application (i.e. its dapr or daprd instance) from the Dapr applications tree view. If the application does not shut down nominally after debugging, it's not always obvious how/where to stop it so that the user can restart without fear of strange conflicts. (Especially since the dapr CLI does not show arbitrarily started daprd instances.)

The applications tree view could offer a "kill" context menu command (at least for instances that it, itself, started) to allow for quick, forced shutdowns and restarts.
@philliphoff philliphoff added feature New feature P2 Moderate priority investigate Issues that require investigation labels Mar 23, 2020
@philliphoff philliphoff added this to the 0.3.0 milestone Mar 23, 2020
@philliphoff philliphoff modified the milestones: 0.3.0, 0.4.0 Sep 10, 2020
@philliphoff philliphoff modified the milestones: 0.4.0, Future Nov 30, 2020
@philliphoff philliphoff mentioned this issue Jun 8, 2021
Closed
@sk593 sk593 mentioned this issue Jun 9, 2021
Merged
@jasonviviano
Copy link
Contributor

Description

Background

Currently there is no way to kill a Dapr application detected from the UI found in the VS Code extension. Users would have to either kill the debugging process started that has initiated the Dapr application or kill the application from what ever terminal it has been started.

Request

Add a command that kills a specific Dapr application when that application is selected. This command should be a right click command option that only effects the selected Dapr application.

Mockup

Screen Shot 2021-06-21 at 1 46 32 PM

@sk593 sk593 modified the milestones: Future, 0.5.0 Jun 29, 2021
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jul 2, 2021
@sk593
Merge branch 'main' into stopApp-microsoft#81
019c712
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jul 13, 2021
@sk593
Merge branch 'main' of github.com:sk593/vscode-dapr into stopApp-micr…
c48543e 
…osoft#81
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jul 15, 2021
@sk593
Merge branch 'main' of github.com:sk593/vscode-dapr into stopApp-micr…
0df54e1 
…osoft#81
sk593 added a commit that referenced this issue Jul 22, 2021
@sk593
Implemented issue #81 (allow stopping dapr apps) (#179)
7b3970b 
* added stop app command and documentation

* updated stop app to use process wrapper

* removed comments and temp bug fix for dapr list error

* added stop app assets

* removed unused imports and fixed eslint errors

* minor changes to var names

* updated stop application to kill instances of dapr and daprd

* windows support + minor refactoring

* updating package-lock

* changed kill proc to SIGTERM

* updated to use which module to find daprd executable

* adding package.json

* updated package-lock

* removed unused imports

* updated error handling

* moved stop logic to dapr cli client

* added open telemetry module
@sk593 sk593 closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature investigate Issues that require investigation P2 Moderate priority
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@philliphoff @sk593 @jasonviviano