Implemented issue #81 (allow stopping dapr apps) #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
philliphoff
reviewed
Jun 10, 2021
philliphoff
reviewed
Jun 10, 2021
philliphoff
reviewed
Jun 28, 2021
philliphoff
reviewed
Jun 28, 2021
philliphoff
reviewed
Jun 28, 2021
philliphoff
reviewed
Jun 28, 2021
philliphoff
reviewed
Jul 2, 2021
philliphoff
reviewed
Jul 2, 2021
philliphoff
reviewed
Jul 2, 2021
philliphoff
reviewed
Jul 2, 2021
philliphoff
reviewed
Jul 2, 2021
philliphoff
reviewed
Jul 7, 2021
philliphoff
reviewed
Jul 7, 2021
philliphoff
reviewed
Jul 7, 2021
philliphoff
reviewed
Jul 14, 2021
| @@ -1,3 +1,6 @@ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-call */ | |||
There was a problem hiding this comment.
Nit: we prefer to disable linting rules for individual lines rather than whole files. (And there are often tricks to make the TS compiler happy, than can avoid having to disable certain kinds of rules at all.)
philliphoff
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Stop App command to address #81 and added documentation to the readme. There is a bug with the extension not being able to pick up dapr processes (#169) so testing this will require a temporary fix similar to whats proposed here (#170)
@philliphoff @pkedy @artursouza