Setup-focused getting started walkthrough #588
Conversation
| @@ -121,6 +147,19 @@ | |||
| "path": "walkthrough/testing.png", | |||
| "altText": "Testing" | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
@digitarald java getting started page will be opened on the top of welcome page? I think better to be opened on the right hand side. also, a good demo for side-by-side view.
There was a problem hiding this comment.
Correct, this is on the list for this release to allow. In my testing, the current Java Tools welcome page does not trigger any side by side views, so I would not block on this.
|
@yaojinyang @Eskibear recorded a demo of the latest code with a side-by-side onboarding flow: java-walkthrough-v0.mp4 |
package.json
Outdated
| @@ -121,6 +147,19 @@ | |||
| "path": "walkthrough/testing.png", | |||
| "altText": "Testing" | |||
| } | |||
| }, | |||
| { | |||
| "id": "java.showTesting", | |||
There was a problem hiding this comment.
This task is not shown possibly, because of its duplicated id. Is it on purpose?
There was a problem hiding this comment.
No, an oversight from copy/pasta.
|
@yaojinyang @Eskibear are there any specific concerns or questions that need need to be addressed to move this pull request forward? |
|
@digitarald Thank you for the rephrasing and nice looking screenshots, it looks much better. I haven't merge this PR because:
Besides I don't have other concern to merge it as it's a feature branch. |
|
|
The updated pull request has the markdown,
A lot can be tweaked here. First step is opening the walkthrough after extension installation; next doing more complex heuristics like opening the walkthrough when the extension activates and no items have been completed yet. |
|
@Eskibear thanks for merging! What are your plans for merging https://github.com/microsoft/vscode-java-pack/tree/getting-started-insider into master, so we can start testing the content? |
|
I can always prepare a private build from this branch for testing. Or do you want me to ship it directly into marketplace? |
|
@digitarald we'll release a new version this week. As long as it doesn't affect stable version users, I think it's okay for insider users to have a test before we throughly polish these steps/use cases. |
That would work, as it doesn't do anything for existing users. We could also wait to have an experimentation framework in place, that prevents the build-in Java welcome logic when VS Code has extension walkthroughs enabled. |
Do you have the timeline when it would be ready? |
|
I'd plan for microsoft/vscode#122592 to land in the next iteration and we can start as soon as extensions adopted it. |
* integrated feature tour with vscode's native getting started page Signed-off-by: Yan Zhang <[email protected]> * update schema as gettingStartedService changed in vscode Signed-off-by: Yan Zhang <[email protected]> * Setup-focused getting started walkthrough (#588) * Making walkthrough more setup focused. * Snapper copy for walkthrough * Added multi-button and markdown updates * don't enable proposed API * update Java walkthrough Signed-off-by: Yan Zhang <[email protected]> * fix wording Signed-off-by: Yan Zhang <[email protected]> Co-authored-by: Harald Kirschner <[email protected]>
Posting these ideas for the shape of Java's walkthrough. I'd love feedback on this approach and expanding on it further:
Outcome:
whenclause that only shows the runtime step when no JDK was detectedwhenclause to only show open folder when workspace doesn't have a folder open.whenclauses could further be used for contextual tasks, like detecting Springboard in a project and recommending the extension.Feel free to try it out. Meanwhile, I am working on recording this to help with feedback.
If we think this direction works well, I would spend more time on polishing the copy.