Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup-focused getting started walkthrough #588

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,32 @@
"title": "welcome to Java",
"description": "Java description",
"tasks": [
{
"id": "java.runtime",
"title": "Configure Java Runtime",
"description": "Pick the right JDK for running Java with the built-in configurator.",
"button": {
"command": "java.runtime",
"title": "Configure Java Runtime"
},
"media": {
"path": "walkthrough/runtime.png",
"altText": "Open Project Folder"
}
},
{
"id": "java.extGuide",
"title": "Java Extensions",
"description": "Additional s extensions for Java development.",
"button": {
"command": "java.extGuide",
"title": "Configure Java Runtime"
},
"media": {
"path": "walkthrough/extGuide.png",
"altText": "Open Project Folder"
}
},
{
"id": "java.openProjectFolder",
"title": "Open Project Folder",
Expand All @@ -67,7 +93,7 @@
"path": "walkthrough/open-project.png",
"altText": "Open Project Folder"
},
"when": "!isMac"
"when": "!isMac && workspaceFolderCount == 0"
},
{
"id": "java.openProjectFolder.mac",
Expand All @@ -81,7 +107,7 @@
"path": "walkthrough/open-project.png",
"altText": "Open Project Folder"
},
"when": "isMac"
"when": "isMac && workspaceFolderCount == 0"
},
{
"id": "java.showProjectExplorer",
Expand Down Expand Up @@ -121,6 +147,19 @@
"path": "walkthrough/testing.png",
"altText": "Testing"
}
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitarald java getting started page will be opened on the top of welcome page? I think better to be opened on the right hand side. also, a good demo for side-by-side view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this is on the list for this release to allow. In my testing, the current Java Tools welcome page does not trigger any side by side views, so I would not block on this.

{
"id": "java.showTesting",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task is not shown possibly, because of its duplicated id. Is it on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, an oversight from copy/pasta.

"title": "Quick start with Java",
"description": "Just starting with Java? Get hands on with these tutorials to learn the fundamentals of Java editing & debugging.",
"button": {
"command": "java.gettingStarted",
"title": "Open Tutorials"
},
"media": {
"path": "walkthrough/tutorials.png",
"altText": "Tutorials"
}
}
]
}
Expand Down
Binary file added walkthrough/extGuide.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added walkthrough/runtime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added walkthrough/tutorials.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.