Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing a comma in a string that is an argument to a function causes the pop up box to display #2057

Closed
jakegt1 opened this issue Jun 25, 2018 · 8 comments · Fixed by #2178 or #2072
Closed
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@jakegt1
Copy link

jakegt1 commented Jun 25, 2018

When writing arguments to functions, the python module shows a pop up box showing the next argument and its documentation, which can be removed by clicking away among other things. However, if you're writing a string as an argument, if you ever write a comma it will cause the popup box to re-fire.

Environment data

  • VS Code version: 1.24.1
  • Extension version (available under the Extensions sidebar): 2018.6.0
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): Python 3.5.4
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Relevant/affected Python packages and their versions: N/A

Actual behavior

Pop up box for functions shows when a comma is written inside of a string, not just outside of a string

Expected behavior

Pop up box should not fire if the comma is inside a string

Steps to reproduce:

Write code that would execute a function, add a string as an argument, click to remove the pop up box, write a comma in the string which will show the pop up box.

str("This is my string,")   # Comma causes the box to pop up
@DonJayamanne
Copy link

Please could you send a screen shot of the pop-up.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. info-needed Issue requires more information from poster labels Jun 25, 2018
@d3r3kk
Copy link

d3r3kk commented Jun 25, 2018

image

Verified.

@d3r3kk d3r3kk added needs PR and removed info-needed Issue requires more information from poster labels Jun 25, 2018
@MikhailArkhipov
Copy link

MikhailArkhipov commented Jun 25, 2018

It is a result of a "hover" request

@DonJayamanne
Copy link

@d3r3kk Please retest with the mouse pointer out of the way.

@d3r3kk
Copy link

d3r3kk commented Jun 25, 2018

Has nothing to do with hover. Can repro with mouse off screen completely. Nothing appears until I type the comma. Screencap, including the position of the mouse cursor:
image

Actual mouse hover shows str:[word in string under cursor], not the popup shown above, like so:
image

@jakegt1
Copy link
Author

jakegt1 commented Jun 26, 2018

Sorry for being poor on my explanation, but ye that's the bug.

@d3r3kk
Copy link

d3r3kk commented Jun 26, 2018

@jakegt1 not at all! Thanks very much for the report. (We need to verify each bug reported and it was a lackluster verification on my part if anything!). Now that we are aware of the issue, we'll triage this, probably after the July release, not sure when exactly.

@d3r3kk d3r3kk added this to the Jul 2018 milestone Jun 26, 2018
@d3r3kk d3r3kk self-assigned this Jun 26, 2018
@d3r3kk
Copy link

d3r3kk commented Jun 26, 2018

d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Jun 29, 2018
- issue microsoft#2057
- struggling with test framework & signature provider!
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Jun 29, 2018
- issue microsoft#2057
- struggling with test framework & signature provider!
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
5 participants