Do not open "save as" window when running existing Python files #21209

profRidha · 2023-05-09T22:22:26Z

Type: Bug

Behaviour

Interpret a python script by clicking on the button "Run Python File in Terminal"
(The file (script) is already saved and the "Save Before Run" option is on "always")

Expected

Automatic save Before Run

Actual

A window that asks to save file as ...

Steps to reproduce:

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.11.0
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

User Settings


languageServer: "Pylance"

terminal
• executeInFileDir: "<placeholder>"

Extension version: 2023.9.11291529
VS Code version: Code 1.78.1 (6a995c4f4cc2ced6e3237749973982e751cb0bf9, 2023-05-04T09:49:36.514Z)
OS version: Windows_NT ia32 10.0.19042
Modes:
Sandboxed: Yes

System Info

Item	Value
CPUs	Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz (4 x 3293)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: unavailable_off vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	3.41GB (0.75GB free)
Process Argv	--crash-reporter-id 012849ce-a2cf-40d8-9464-65f5ea7e9618
Screen Reader	no
VM	0%

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyonecf:30548226
3biah626:30602489
pyind779:30671433
89544117:30613380
pythonsymbol12:30671437
6233i204:30730053
vsctsb:30705553
azdwalk:30721579
pythonms35:30701012
pythonfmttext:30731395
fixshowwlkth:30730052
pythongtdpathcf:30731979

The text was updated successfully, but these errors were encountered:

karrtikr · 2023-05-10T20:50:29Z

Are you referring to this?

It only applies to "Task" as per description.

profRidha · 2023-05-10T22:05:25Z

@karrtikr ; Yes that's it ;
I explain the problem again :
if I interpret a python script (by clicking on the button "Run Python File in Terminal") I always have a window that asks me to save my file! except that the latter is already saved and the "Save Before Run" option is on "always" ! ("ctrl + F5" still works)
to note that no problem for earlier versions (<= 2023.9.11241009)

karrtikr · 2023-05-10T22:16:11Z

I understand, although "Save before run" option only applies when running "Tasks" (defined in tasks.json). Running Python files is not a task, so that setting does not apply here.

to note that no problem for earlier versions (<= 2023.9.11241009)

Although we can try to revert to this behavior you described, whcih should work for you. Marking this as a bug.

karrtikr · 2023-05-10T22:23:48Z

Opened microsoft/vscode#182124 on VSCode.

Closes #21209

…osoft#21232) Closes microsoft#21209

…on release 2023.10.0 Merge pull request #122 from posit-dev/merge/2023.10.0 Merging upstream vscode-python release 2023.10.0 -------------------- Commit message for posit-dev/positron-python@fc0926f: Add typings to get updated EnvironmentVariableCollection API -------------------- Commit message for posit-dev/positron-python@8c11f29: Merge remote-tracking branch 'upstream/release/2023.10' -------------------- Commit message for posit-dev/positron-python@fea895f: Update version and readme for release (posit-dev/positron-python#21388) Co-authored-by: Soojin (Min) Choi <[email protected]> -------------------- Commit message for microsoft/vscode-python@ad9c899: Update version for release candidate (microsoft/vscode-python#21369) -------------------- Commit message for microsoft/vscode-python@a395e2e: fix bug so canceling debug works in rewrite (microsoft/vscode-python#21361) fixes microsoft/vscode-python#21336 -------------------- Commit message for microsoft/vscode-python@be829b3: Unittest for large workspaces (microsoft/vscode-python#21351) follows the same steps as making pytest compatible with large workspaces with many tests. Now test_ids are sent over a port as a json instead of in the exec function which can hit a cap on # of characters. Should fix microsoft/vscode-python#21339. -------------------- Commit message for microsoft/vscode-python@cd76ee1: add pythonTestAdapter to experiment enum (microsoft/vscode-python#21357) allow people to opt in and out of the pythonTestAdapter rewrite via the settings `python.experiment.optInto` or `python.experiment.optOutfrom` -------------------- Commit message for microsoft/vscode-python@dbd0b73: adding extra log messages for rewrite debugging (microsoft/vscode-python#21352) These logs print errors and other bits of information which will be helpful for debugging workflows of users where we need to get information such as args or which step in the process they got to. -------------------- Commit message for microsoft/vscode-python@d968b8c: Dont show command for button trigger in command pallet (microsoft/vscode-python#21350) Fixes microsoft/vscode-python#21322 -------------------- Commit message for microsoft/vscode-python@e9a8dd5: remove duplicates from test_ids array (microsoft/vscode-python#21347) this will partially remediate microsoft/vscode-python#21339 in regards to the duplicate IDs being run. -------------------- Commit message for microsoft/vscode-python@f148139: allow pytest tests to handle multiple payloads (microsoft/vscode-python#21301) As part of the switch to allow for dynamic run- the pytest discovery and execution tests are now switched to be take lists of dicts where the dicts are the payloads. -------------------- Commit message for microsoft/vscode-python@c213491: Apply environment variables after shell initialization scripts are run in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21290) For microsoft/vscode-python#11039 microsoft/vscode-python#20822 Closes microsoft/vscode-python#21297 Update proposed APIs to be used in Terminal activation experiment. -------------------- Commit message for microsoft/vscode-python@72f7ef8: Set up testing rewrite experiment (microsoft/vscode-python#21258) is the beginning of this issue: microsoft/vscode-python#21150, in that it will start the process of implementing the setting in the extension -------------------- Commit message for microsoft/vscode-python@4109228: fix debugging with new pytest run script (microsoft/vscode-python#21299) fix debugging for run_pytest_script.py setup -------------------- Commit message for microsoft/vscode-python@b916981: remove unneeded multiroot code (microsoft/vscode-python#21295) removed extra steps to wrap data since this creates duplicate folders in the controller and only keeps the most recent instead of all the roots from different workspaces. -------------------- Commit message for microsoft/vscode-python@e2a9cec: allow large scale testing (microsoft/vscode-python#21269) allows new testing rewrite to handle 500+ tests and load and run these tests. High limit tested was 10,000 tests. -------------------- Commit message for microsoft/vscode-python@f2f5fe2: Check config type in the ChildProcessAttachEvents (microsoft/vscode-python#21272) -------------------- Commit message for microsoft/vscode-python@4b4e5b7: Update pyright version (microsoft/vscode-python#21296) Fix error in tests, updating pyright version -------------------- Commit message for microsoft/vscode-python@c9a7268: Revert "Remove hack to check the vscode version" (microsoft/vscode-python#21294) Reverts microsoft/vscode-python#21180 For microsoft/vscode-python#20769 -------------------- Commit message for microsoft/vscode-python@a74f1d1: Detect installed packages in the selected environment (microsoft/vscode-python#21231) Fixes microsoft/vscode-python#21140 -------------------- Commit message for microsoft/vscode-python@b0ebc9b: Enable debug pytest (microsoft/vscode-python#21228) fixes microsoft/vscode-python#21147 --------- Co-authored-by: Aidos Kanapyanov <[email protected]> Co-authored-by: Karthik Nadig <[email protected]> -------------------- Commit message for microsoft/vscode-python@be9662f: revert testing to using socket (microsoft/vscode-python#21242) switch back to using a socket instead of an output file for use in the plugin communication during testing. This should work now that we resolved the issue with python path for windows. -------------------- Commit message for microsoft/vscode-python@b4a47bb: Add reload flag on fastApi provider (microsoft/vscode-python#21241) -------------------- Commit message for microsoft/vscode-python@fcfc54c: Add option for pyenv interpreters when creating environments with venv (microsoft/vscode-python#21219) Resolves microsoft/vscode-python#20881 . Testing: Behaves as expected when testing with Extension Development Host: ![image](https://github.com/microsoft/vscode-python/assets/30149293/d114d9ab-f2d8-4273-877b-d7dd030cfe76) -------------------- Commit message for microsoft/vscode-python@b3d43e5: Do not open "save as" window when running existing Python files (microsoft/vscode-python#21232) Closes microsoft/vscode-python#21209 -------------------- Commit message for microsoft/vscode-python@b0da28c: Remove IS_WINDOWS constant in favor of PlatformService (microsoft/vscode-python#21157) Solves partially microsoft/vscode-python#8542 -------------------- Commit message for microsoft/vscode-python@0c4fa40: Change name of command to run Python files in separate terminals (microsoft/vscode-python#21229) Closes microsoft/vscode-python#14094 -------------------- Commit message for microsoft/vscode-python@1533818: Added option to run multiple Python files in separate terminals (microsoft/vscode-python#21223) Closes microsoft/vscode-python#21215 microsoft/vscode-python#14094 Added the option to assign a dedicated terminal for each Python file: ![image](https://github.com/microsoft/vscode-python/assets/13199757/b01248e4-c826-4de0-b15f-cde959965e68) -------------------- Commit message for microsoft/vscode-python@eb9fde3: Add `createEnvironment.contentButton` setting (microsoft/vscode-python#21212) Closes microsoft/vscode-python#20982 --------- Co-authored-by: Luciana Abud <[email protected]> -------------------- Commit message for microsoft/vscode-python@5eef525: Add logging when interpreter path changes (microsoft/vscode-python#21210) For microsoft/vscode-python#21208 -------------------- Commit message for microsoft/vscode-python@8d291f7: Disable "snippets" expansion in Jedi LSP (microsoft/vscode-python#21194) This brings the Jedi based completion experience in line with that provided by Pylance. Completions now insert only the current symbol rather than assuming that the user wants to e.g: call that symbol. This means for example that completing `max` will insert just `max` rather `max(arg1, arg2)`. While for this case this may be seen as less useful, it means that insertions in places where a call is not desired (such as imports and typing contexts) will not be forced to manually remove the parentheses and template arguments which might otherwise be inserted. Users can still use the signature support UI to explore signatures and of course insertion of an opening parenthesis will still insert a closing one. Hopefully this new configuration will be preferable to a majority of users. I've done some light testing to check that this disables the described additional completion, however I'm not massively familiar with JediLSP so I'm not sure what other behaviours this will disable. Fixes microsoft/vscode-python#15858 -------------------- Commit message for microsoft/vscode-python@a85eb3b: Fix startup telemetry issue (microsoft/vscode-python#21203) Could fix microsoft/vscode-python#20874 based on error trace. -------------------- Commit message for microsoft/vscode-python@17daae4: Open separate Python terminals when running different Python files (microsoft/vscode-python#21202) Closes microsoft/vscode-python#21097 Closes microsoft/vscode-python#14094 -------------------- Commit message for microsoft/vscode-python@f0253e5: Use actions from `vscode-github-triage-actions` in all Python automations (microsoft/vscode-python#21178) -------------------- Commit message for microsoft/vscode-python@678f70d: Remove hack to check the vscode version (microsoft/vscode-python#21180) Closed: microsoft/vscode-python#20769 -------------------- Commit message for microsoft/vscode-python@6bdada0: Use `saveEditor` proposed API for running untitled Python files (microsoft/vscode-python#21183) Closes microsoft/vscode-python#21182 Lead-authored-by: Eleanor Boyd <[email protected]> Co-authored-by: Peter Law <[email protected]> Co-authored-by: Carlos Piña Martinez <[email protected]> Co-authored-by: Jonathan Rayner <[email protected]> Co-authored-by: Pete Farland <[email protected]> Co-authored-by: paulacamargo25 <[email protected]> Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Signed-off-by: GitHub <[email protected]>

github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 9, 2023

karthiknadig added the feature-request Request for new features or functionality label May 10, 2023

karthiknadig assigned karrtikr May 10, 2023

karthiknadig added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels May 10, 2023

karrtikr added area-terminal needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels May 10, 2023

github-actions bot added the info-needed Issue requires more information from poster label May 10, 2023

karrtikr changed the title ~~Save Before Run~~ Do not open "save as" window when running existing Python files May 10, 2023

karrtikr removed the info-needed Issue requires more information from poster label May 10, 2023

karrtikr mentioned this issue May 10, 2023

Untitled files are not considered dirty? microsoft/vscode#182124

Closed

karrtikr added this to the May 2023 milestone May 11, 2023

karrtikr mentioned this issue May 11, 2023

Do not open "save as" window when running existing Python files #21232

Merged

karrtikr closed this as completed in #21232 May 11, 2023

karrtikr pushed a commit that referenced this issue May 11, 2023

Do not open "save as" window when running existing Python files (#21232)

b3d43e5

Closes #21209

eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this issue May 12, 2023

Do not open "save as" window when running existing Python files (micr…

d5db25e

…osoft#21232) Closes microsoft#21209

mjbvz added the verified Verification succeeded label May 31, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023

eleanorjboyd removed the needs PR Ready to be worked on label Dec 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not open "save as" window when running existing Python files #21209

Do not open "save as" window when running existing Python files #21209

profRidha commented May 9, 2023 •

edited

Loading

karrtikr commented May 10, 2023

profRidha commented May 10, 2023 •

edited

Loading

karrtikr commented May 10, 2023

karrtikr commented May 10, 2023

Do not open "save as" window when running existing Python files #21209

Do not open "save as" window when running existing Python files #21209

Comments

profRidha commented May 9, 2023 • edited Loading

Behaviour

Expected

Actual

Steps to reproduce:

Diagnostic data

karrtikr commented May 10, 2023

profRidha commented May 10, 2023 • edited Loading

karrtikr commented May 10, 2023

karrtikr commented May 10, 2023

profRidha commented May 9, 2023 •

edited

Loading

profRidha commented May 10, 2023 •

edited

Loading