Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Smart Send out of experiment #23045

Closed
anthonykim1 opened this issue Mar 10, 2024 · 1 comment · Fixed by #23067
Closed

Remove Smart Send out of experiment #23045

anthonykim1 opened this issue Mar 10, 2024 · 1 comment · Fixed by #23067
Assignees
@anthonykim1
Labels
area-repl feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2024

Comments

@anthonykim1
Copy link

Now that smart send feature along with its setting to turn on and off, has been sitting in 100% experiment for awhile, we should take it out of the experiment.
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality area-repl labels Mar 10, 2024
@anthonykim1 anthonykim1 self-assigned this Mar 10, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 10, 2024
@kieferrm kieferrm mentioned this issue Mar 11, 2024
Closed
36 tasks
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Mar 11, 2024
This was referenced Mar 12, 2024
Closed
Merged
anthonykim1 added a commit that referenced this issue Mar 14, 2024
@anthonykim1
Take Smart Send Out of Experiment (#23067)
ff4c688 
Resolves: #23045
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this issue Mar 14, 2024
@anthonykim1
Take Smart Send Out of Experiment (microsoft#23067)
7eabfbb 
Resolves: microsoft#23045
@anthonykim1 anthonykim1 added this to the March 2024 milestone Mar 22, 2024
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Mar 22, 2024
@anthonykim1
Copy link
Author

Verification steps:

  1. Go to settings
  2. Search for Python.REPL: Enable REPLSmart Send
  3. Open existing Python file or create one of your choice with valid code (Python 3.8+)
  4. Turn setting for smart send on and off to make sure you get the correct behavior.
  5. Feel free to test with deprecated code (@python2) to see you get a warning that tells you smart send can not be used.

@roblourens roblourens added the verified Verification succeeded label Mar 26, 2024
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 5, 2024
@anthonykim1
Take Smart Send Out of Experiment (microsoft/vscode-python#23067)
b147aac 
Resolves: microsoft/vscode-python#23045
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 8, 2024
@anthonykim1 @wesm
Take Smart Send Out of Experiment (microsoft/vscode-python#23067)
6d74b7a 
Resolves: microsoft/vscode-python#23045
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
area-repl feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2024
2 participants
@roblourens @anthonykim1