Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Smart Send Out of Experiment #23067

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

anthonykim1
Copy link

Resolves: #23045

@anthonykim1 anthonykim1 added experimenting Feature is part of an experiment area-repl labels Mar 13, 2024
@anthonykim1 anthonykim1 self-assigned this Mar 13, 2024
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality and removed experimenting Feature is part of an experiment labels Mar 13, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review March 13, 2024 22:38
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 13, 2024
@anthonykim1 anthonykim1 merged commit ff4c688 into microsoft:main Mar 14, 2024
37 of 39 checks passed
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Mar 14, 2024
anthonykim1 added a commit that referenced this pull request Mar 14, 2024
Forgot to set default value to true here:
#23067
It was true before removing experiment code since we had experiment to
100%, which effectively overrode the smart send setting value to True.
@microsoft microsoft deleted a comment from w1s3one805 Mar 15, 2024
@microsoft microsoft deleted a comment from w1s3one805 Mar 15, 2024
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
Forgot to set default value to true here:
microsoft/vscode-python#23067
It was true before removing experiment code since we had experiment to
100%, which effectively overrode the smart send setting value to True.
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
Forgot to set default value to true here:
microsoft/vscode-python#23067
It was true before removing experiment code since we had experiment to
100%, which effectively overrode the smart send setting value to True.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Smart Send out of experiment
3 participants