Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies cannot be configured inside package.json #742

Closed
ssbarnea opened this issue Jun 17, 2022 · 1 comment · Fixed by #743
Closed

Dependencies cannot be configured inside package.json #742

ssbarnea opened this issue Jun 17, 2022 · 1 comment · Fixed by #743
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug released

Comments

@ssbarnea
Copy link
Contributor

I think that when this bug was fixed the ability to load the dependencies from package.json file did not work.

Based on REAME.md file, we were supposed to be able to configure inside package.json:

{
  ...
  "vsce": {
    "dependencies": false,
    "useYarn": false
  }
}

While useYarn works as expected and allow you to avoid having to add --no-yarn, the dependencies option has not effect at all, preventing you from fixing the package command from inside config.

That is indeed a big deal if you do not call vsce package yourself and not having ability to add the required extra arguments.

I tried to look at the d797b8d to spot the bug but I was not able to find exact what was missed.

Note: PR incoming, already fixed it locally.

ssbarnea added a commit to ssbarnea/vscode-vsce that referenced this issue Jun 17, 2022
@joaomoreno joaomoreno self-assigned this Jun 17, 2022
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jun 17, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 2.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ssbarnea added a commit to ssbarnea/vscode-extension-tester that referenced this issue Jun 25, 2022
As vsce version does not get updated magically, we need to upgrade
the minimum version in order to allow building projects with yarn.

Fixes redhat-developer#451
Related: microsoft/vscode-vsce#742
ssbarnea added a commit to ssbarnea/vscode-extension-tester that referenced this issue Jun 25, 2022
As vsce version does not get updated magically, we need to upgrade
the minimum version in order to allow building projects with yarn.

Fixes redhat-developer#451
Related: microsoft/vscode-vsce#742
ssbarnea added a commit to ssbarnea/vscode-extension-tester that referenced this issue Sep 15, 2022
As vsce version does not get updated magically, we need to upgrade
the minimum version in order to allow building projects with yarn.

Fixes redhat-developer#451
Related: microsoft/vscode-vsce#742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants