Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn compatibility #460

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix yarn compatibility #460

merged 1 commit into from
Sep 16, 2022

Conversation

ssbarnea
Copy link
Member

As vsce version does not get updated magically, we need to upgrade
the minimum version in order to allow building projects with yarn.

Fixes #451
Related: microsoft/vscode-vsce#742

@ssbarnea
Copy link
Member Author

@odockal What is weird is I seen some code inside packageExtension where it checks if vsce is installed on that parent level and is trying to use it.

The funny bit is that this logic did not work with a yarn based extension and it still attempted to run vsce from within vscode-extension-tester itself, which was older than the versions we wanted to use. Basically that feature did not work in that case.

        let vscePath = path.join(__dirname, '..', '..', 'node_modules', '.bin', 'vsce');
        if (!fs.existsSync(vscePath)) {
            vscePath = path.join('node_modules', '.bin', 'vsce');
        }

That is the bit of code that made it still use the outdated version from vscode-ansible/node_modules/vscode-extension-tester/node_modules/.bin/vsce instead of vscode-ansible/node_modules/.bin/vsce

If I understood the code correctly the order is exactly the opposite, as the version from within extest itself is preferred, so user does not have much control on how to use it.

@ssbarnea ssbarnea closed this Jul 25, 2022
@ssbarnea ssbarnea reopened this Jul 25, 2022
As vsce version does not get updated magically, we need to upgrade
the minimum version in order to allow building projects with yarn.

Fixes redhat-developer#451
Related: microsoft/vscode-vsce#742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with modern yarn setups (v2+)
3 participants