Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom In/Out should not modify whole window. #1348

Closed
MiguelLattuada opened this issue Dec 15, 2015 · 8 comments
Closed

Zoom In/Out should not modify whole window. #1348

MiguelLattuada opened this issue Dec 15, 2015 · 8 comments
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality zoom VS Code window zoom issues
Milestone

Comments

@MiguelLattuada
Copy link

Editor window should not be modified when zooming in/out.
screen shot 2015-12-15 at 5 46 52 pm

Instead of that, just code rows (.view-lines div) should be scaled (transformed or font resized).
screen shot 2015-12-15 at 6 02 23 pm

This is kind of shortcut for resizing, does not mean anything.
screen shot 2015-12-15 at 6 15 24 pm

And sure, kind of zoom status should be displayed at the bottom status bar.
screen shot 2015-12-15 at 6 04 12 pm

  • Images under bolded text, has been modified.
@stkb
Copy link
Contributor

stkb commented Dec 15, 2015

Don't agree: the current zoom behavior is exactly what I want. You can always change the editor.fontSize setting for larger or smaller editor text. Though it's true that there aren't shortcut keys for that.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Dec 16, 2015
@dbaeumer dbaeumer added this to the Backlog milestone Dec 16, 2015
@dbaeumer
Copy link
Member

@alexandrudima assigning to you because of the short cut request.

@stkb
Copy link
Contributor

stkb commented Dec 16, 2015

I should add though, thanks to the new persisted window.zoomLevel setting, it's now more a set-and-forget thing for me. So as long as that stays, I wouldn't mind if the existing ctrl+-/= shortcuts were remapped to just change the editor text size instead.

@gamtiq
Copy link

gamtiq commented Feb 24, 2016

Don't agree: the current zoom behavior is exactly what I want.

+1
It's quite a useful feature.
Unfortunately zoom level that is set in work session isn't restored after VS Code is closed and the reopened (#291).

@purplecabbage
Copy link

+1 Please map ctrl+- to editor view, or better yet, whichever view has focus.
The icons in the top left changing size makes it obvious that the whole window is just one big webview ...
personally, I would not expect the icons to be zoomable via ctrl-+

@anyong
Copy link

anyong commented Apr 24, 2016

I would really like to be able to set CTRL+/- to increase editor.fontSize and editor.lineHeight equally. The current zoom behavior is not good for me, because I work with different languages and some have characters with smaller fonts (Thai, Chinese) and I would like to be able to easily increase the font size when working with those characters.

I recently looked into hacking this out in an extension, only to find out that it's basically impossible to set a user preference via an extension (which makes sense), so it appears there's currently no way to do this.

@alexdima alexdima added workbench editor-core Editor basic functionality labels Oct 27, 2016
@alexdima alexdima removed their assignment Oct 27, 2016
@mjbvz mjbvz mentioned this issue Dec 9, 2016
@Tekbr
Copy link

Tekbr commented Dec 9, 2016

-- Sorry for the English, I used Google Translator --

Based on issue #14979 with comment.

1- Ctrl + + It should zoom in on the editor, the file we're moving, not the zoom of the whole program.
2- Ctrl + - You should zoom out within the editor, the file you are moving, not the zoom of the entire program.
3- Ctrl + 0 You should zoom back to the default, the file you are moving, not the zoom of the entire program.

4- Ctr + +, Ctr + - should work the same way when we use "editor.mouseWheelZoom", by only zooming the file. And using Ctrl + 0 returns to the default.

5- Ctr + = You should do nothing. The zoom continues. You must unlink this function.
6- Ctrl + 0 of the non-numeric keyboard does not reset the zoom.

These shortcut keys should be valid for both numeric and non-numeric keys. In the menu you should change the registration Ctr + = by Ctrl + +

Why not set specific sizes for the UI? Maybe some problems mentioned by @alexandrudima would decrease!!

In fact I am 100% in favor of eliminating the entire UI zoom we're shipping with, it causes many issues with font anti-aliasing for example and I have to maintain extraneous code to work around it (i.e. not using translate3d when the UI zoom is not 100%)

Example: Small, Normal, Large, Extra large. To set proportions, do a search with someone who uses sizes other than their normal size.

@bpasero
Copy link
Member

bpasero commented Nov 16, 2017

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

@bpasero bpasero closed this as completed Nov 16, 2017
@bpasero bpasero added the zoom VS Code window zoom issues label Nov 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Tyriar added a commit that referenced this issue Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality zoom VS Code window zoom issues
Projects
None yet
Development

No branches or pull requests

9 participants