-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zooming with ctrl+mousewheel combination #6990
Conversation
By analyzing the blame information on this pull request, we identified @alexandrudima and @egamma to be potential reviewers |
Hi @kisstkondoros, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
I am not sure we want to zoom the entire UI when you use the mousewhell, I would expect only the editor font to increase. Thereby moving to @alexandrudima |
@bpasero this change is exactly about that, it changes the font-size and line-height for the editor only (not a UI zoom) |
Ah nice, even better 👍 |
Currently Ctrl + +/- zooms the entire UI. I hope that behavior will change too? That is, only the code area font size will change? |
@asifm I thought about including that as well, but I wanted to leave this simple. |
@kisstkondoros Looks like there's an open issue #1348 and some differences of opinion. I like what @purplecabbage suggested: "Please map ctrl+- to editor view, or better yet, whichever view has focus." |
👍 Very nice, thank you! I shuffled the code around to bring all the logic in the /editor/ folder (not have editor knowledge in /base/) and to make it that ctrl + scroll is looked for only on editor (not on trees, etc.) |
related #6978