Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zooming with ctrl+mousewheel combination #6990

Merged
merged 1 commit into from
Jun 26, 2016

Conversation

kisstkondoros
Copy link
Contributor

related #6978

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @alexandrudima and @egamma to be potential reviewers

@msftclas
Copy link

Hi @kisstkondoros, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@bpasero
Copy link
Member

bpasero commented May 30, 2016

I am not sure we want to zoom the entire UI when you use the mousewhell, I would expect only the editor font to increase. Thereby moving to @alexandrudima

@kisstkondoros
Copy link
Contributor Author

@bpasero this change is exactly about that, it changes the font-size and line-height for the editor only (not a UI zoom)

@bpasero
Copy link
Member

bpasero commented May 30, 2016

Ah nice, even better 👍

@bpasero bpasero removed their assignment May 30, 2016
@asifm
Copy link

asifm commented Jun 11, 2016

Currently Ctrl + +/- zooms the entire UI. I hope that behavior will change too? That is, only the code area font size will change?

@kisstkondoros
Copy link
Contributor Author

@asifm I thought about including that as well, but I wanted to leave this simple.
I think it is better to file a separate issue for that, I would be more than happy to implement it once this PR is merged 😃

@asifm
Copy link

asifm commented Jun 11, 2016

@kisstkondoros Looks like there's an open issue #1348 and some differences of opinion. I like what @purplecabbage suggested: "Please map ctrl+- to editor view, or better yet, whichever view has focus."

@alexdima alexdima merged commit b1cc4d5 into microsoft:master Jun 26, 2016
alexdima added a commit that referenced this pull request Jun 26, 2016
@alexdima
Copy link
Member

👍 Very nice, thank you! I shuffled the code around to bring all the logic in the /editor/ folder (not have editor knowledge in /base/) and to make it that ctrl + scroll is looked for only on editor (not on trees, etc.)

@alexdima alexdima added this to the June 2016 milestone Jul 1, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants