Feedbacks about the paths autocomplete (v 1.8)

[ggregoire]

• VSCode Version: 1.8

Hey guys! I had a discussion on Hacker News with @mjbvz about this new feature.

I think the feature could be improved by copying what the extension Path Intellisense provides.

Some screenshots will speak for themselves.

Here is the extension:

I didn't look at the code but I would bet that they detect when a string starts with './' or '../' and then list the files and folders in the current or previous directory.

IMO it's perfect and it's exactly what I expect from a paths autocomplete.

For comparison, here is the native feature:

My thoughts:

1. Intellisense suggests a lot of things (paths, snippets, symbols in the current file, etc)!

On this screenshot, the file contains few lines of code (it's the ./index.js of the project) so the list of suggestions is relatively small. But I tried in another project, in a file with 300 LOC and a lot of symbols, and the list of suggestions was really too long.

The suggestion I was looking for was components which is the first folder of the project in alphabetical order. When I started typing, components was not in the first visible suggestions. Actually I had to type almost the full name of the folder, i.e. './compon', to get the suggestion.

2. The 🔧 icon is not really intuitive.

The extension uses a file icon. You could display a folder ( 📁 ) or a file ( 📄 ) in function of the suggestion.

---

Hope these feedbacks can help.

Thanks for the amazing work! 🙂

[mjbvz]

Quick update on the the second issue. I just merged in a fix (#17434) to show both path and direcotry completions with a file icon instead of the generic icon:

I'm also looking into using different icons for directories and files, but we need to make a change on the VSCode side to support a directory completion type (tracked by #17435).

[mjbvz]

@ggregoire Can you please try setting "editor.snippetSuggestions": "none" and checking if you still see the unwanted completions in the paths? It looks like most of those suggestions may be coming from snippets, so this issue may be related to #1304

Thanks

[ggregoire]

Thank for the update on the second issue. It was quick!

Yes this setting removes the snippets suggestions in the paths but I usually use these suggestions, so it's not really practical for me. :)

By the way, there are not only snippets suggestions in the list, there are also all the symbols used in the file:

And actually, I'm not even sure the feature is working. I disabled all my extensions and I'm looking for the directory Login (same level as the file):

On the previous screenshots, it seems like Intellisense proposed config in the suggestions only because there was a symbol config in the file.

--

If it helps to investigate, my user settings:

{
    "editor.fontFamily": "Operator Mono",
    "editor.fontSize": 15, // 14 with default font
    "editor.tabSize": 2,
    "editor.renderIndentGuides": true,
    "files.trimTrailingWhitespace": true
  }

and workspace settings:

{
  "files.associations": {
    "*.js": "javascriptreact"
  },
  "javascript.validate.enable": false
}

Version 1.8.0 without extensions.

[mjbvz]

@ggregoire I'm unable to repo the extra completions showing when trying to complete import foo from './|'. If you do not have a package.json, the completing on an empty require "" path will fallback to word based suggestions from the current document.

A few other questions:

• Does the workspace have a package.json file?
• Does the workspace have a jsconfig.json file?
• If possible, can you please share a simple test project that shows this behavior

Thanks.

[mjbvz]

Closing as I'm unable to reproduce the remaining problem. @ggregoire please let me know if you are still hitting this and I can investigate further.