Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CompletionItemKind.Directory #17435

Closed
mjbvz opened this issue Dec 16, 2016 · 0 comments · Fixed by #17438
Closed

Add CompletionItemKind.Directory #17435

mjbvz opened this issue Dec 16, 2016 · 0 comments · Fixed by #17438
Assignees
@mjbvz
Labels
api ux User experience issues

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 16, 2016

For PR #17434

For path completion in TS and JS, we would like to be able to distinguish between completions for files and directories. Currently only CompletionItemKind.File exists, and none of the other CompletionItemKinds seem appropriate for directories.
@mjbvz mjbvz added api ux User experience issues labels Dec 16, 2016
@mjbvz mjbvz mentioned this issue Dec 16, 2016
Closed
@mjbvz mjbvz self-assigned this Dec 16, 2016
mjbvz added a commit to mjbvz/vscode that referenced this issue Dec 17, 2016
@mjbvz
Add CompletionItemKind.Folder
e4fc7f6 
Fixes microsoft#17435

Adds a new completion item kind for folder/directories. This is useful for path intellisense

For the icons, I copied the icons for folders into the suggestion icon set. Let me know if new ones are needed instead.
@mjbvz mjbvz mentioned this issue Dec 17, 2016
Merged
mjbvz added a commit that referenced this issue Dec 19, 2016
@mjbvz
Add CompletionItemKind.Folder (#17438)
5162e3b 
* Add CompletionItemKind.Folder

Fixes #17435

Adds a new completion item kind for folder/directories. This is useful for path intellisense

For the icons, I copied the icons for folders into the suggestion icon set. Let me know if new ones are needed instead.

* Fix monaco.d.ts
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api ux User experience issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CompletionItemKind.Folder mjbvz/vscode
1 participant
@mjbvz