Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot insert a <div>, automatically corrects to </div> #80600

Closed
chrisdias opened this issue Sep 10, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Closed

cannot insert a <div>, automatically corrects to </div> #80600

chrisdias opened this issue Sep 10, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@octref
Labels
candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded
Milestone
August Recovery 2019

Comments

@chrisdias
Copy link
Member

Mac and Windows
Insiders and 1.38 Stable
All extensions disabled

This looks like a regression.

Consider the following HTML:

<!DOCTYPE html>
<html>
<head>
</head>

<body>
    <div>
         <!-- put cursor here, type in "<div>" then press enter result is "</div>"  -->
    </div>
</body>
</html>

If you put the cursor inside the first <div> and then try to create another div:

image

And then press enter, the result is </div>.

image

In 1.37.1 stable, i get what i expect:

image
@chrisdias chrisdias added the regression Something that used to work is now broken label Sep 10, 2019
@kieferrm kieferrm added the candidate Issue identified as probable candidate for fixing in the next release label Sep 10, 2019
@octref octref removed the regression Something that used to work is now broken label Sep 10, 2019
@octref
Copy link
Contributor

octref commented Sep 10, 2019

It's a bug, not a regression. I can repro in 1.37 as well. @aeschli fyi.

@chrisdias
Copy link
Member Author

hmmm i can't repro this in 1.37.1 so i'll upload a video. also we can sit together tomorrow.

@octref
Copy link
Contributor

octref commented Sep 10, 2019

I see. My repro was wrong.

It seems auto-closing (editor.insertSnippet API) would cancel suggest widget in 1.37.1, but not in latest.

@octref octref added the regression Something that used to work is now broken label Sep 10, 2019
@chrisdias
Copy link
Member Author

here's a video of 1.37.1, then insiders, then 1.38.0:

div

@jrieken
Copy link
Member

jrieken commented Sep 10, 2019

Like caused by fixing #26012 (which I think is still a good fix)

@egamma egamma added this to the August Recovery 2019 milestone Sep 10, 2019
octref added a commit that referenced this issue Sep 10, 2019
@octref
Update html service. Fix #80600
1c5b3fd
octref added a commit that referenced this issue Sep 10, 2019
@octref
Update html service. Fix #80600
337b0cd
octref added a commit that referenced this issue Sep 10, 2019
@octref
Merge pull request #80652 from microsoft/pine/80600
5a12da9 
Update html service. Fix #80600
@jrieken jrieken added the verified Verification succeeded label Sep 11, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
August Recovery 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
5 participants
@egamma @chrisdias @jrieken @octref @kieferrm