Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little falcon #153041

Merged
merged 7 commits into from
Jun 24, 2022
Merged

Little falcon #153041

merged 7 commits into from
Jun 24, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jun 23, 2022 •
edited
Loading

Summary

This PR fixes #145731.

  • Changed the "Modified in/Also modified in" label to a "Modified elsewhere" label when there was more language/scope override data to display.
  • Added a custom hover for the "Modified elsewhere" label so that users can see more information about where else a setting has been modified if they really wanted to

Screenshots

A screenshot showing the editor tabSize setting along with how the NVDA screenreader reads it on Windows
A screenshot showing the editor wordWrap setting along with how the NVDA screenreader reads the setting in general, along with the custom hover in case a user mouses over it. The custom hover is currently not accessible by tab
A screenshot showing the editor wordWrap UI

How the UI looks after toggling the feature flag in case the custom hover doesn't work out:
A screenshot showing override scopes back on one line, and no inline information about overrides from other languages

Remaining items

  • Improve the accessibility provider message
  • Add alt text to the Language > Scope links
  • Merge in the accessibility fixes above
  • Add a feature flag in case merging this feature causes too many issues. The flag only needs to occur in the indicators file rather than in all the code I wrote in this PR
  • Add demo screencaps

Next steps

  • Consider adding a tabstop and hover event handling to the Modified elsewhere indicator so that screenreader users get access to the new hover.

@rzhao271 rzhao271 added this to the June 2022 milestone Jun 23, 2022
@rzhao271 rzhao271 self-assigned this Jun 23, 2022
roblourens
roblourens previously approved these changes Jun 24, 2022
View reviewed changes
@rzhao271 rzhao271 merged commit 614bb1a into main Jun 24, 2022
@rzhao271 rzhao271 deleted the little-falcon branch June 24, 2022 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens left review comments

@sbatten sbatten sbatten approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

Indicate if setting has a language-specific value
3 participants
@rzhao271 @roblourens @sbatten