-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wingetcreate new
fails to parse portable package
#302
Comments
I tried returning
I'm not sure why the version is Maybe I broke things by returning |
I am facing same issue while working with coder |
Stepping through the code, I think the issue is that if an executable does not contain an MS xml manifest file embedded in the binary, then it just fails, instead of continuing as an exe. It's non-trivial to add the manifest in rust projects at the moment, and I think there's lots of programs that don't have it; so I think the correct thing to do would be to allow and handle programs that don't have it. I opened a PR #334 to hopefully fix it |
Me too I'm getting a "failed to parse" error. In my case trying to package from a zipfile containing a installer with a bunch of data files beside it:
Curiously, my zipfile's Setup.exe does in fact have a manifest, according to ResourceHacker: Perhaps it's because it's one folder deep? But I tried rezipping it with the setup files at the root of the zip and uploading it elsewhere and using that url and it still failed to parse, so something's funky somewhere. 🤔 |
@darkvertex Just tested Natron you linked, and it seems to parse fine with both the preview version of |
This should be re-opened IMHO. #334 prevents the vague error, but it does not resolve my issue (failure to parse a particular portable exe). The I entered some placeholder installer switches to see if I could change the installer type after the fact and am also unable to do so. It needs to be possible to override the Would it be too disruptive to always prompt the user to confirm if a given exe is an installer or portable app? |
@bradenhilton This issue got fixed in PR #355, and the fix will probably appear in the next release of winget-create. |
Brief description of your issue
I am attempting to create a manifest for twpayne/chezmoi and
wingetcreate new
gives a generic "Failed to parse the package" error.Steps to reproduce
Run
wingetcreate new https://github.com/twpayne/chezmoi/releases/download/v2.22.0/chezmoi-windows-amd64.exe
.Expected behavior
The command should run successfully, or give a more informative error message.
If I am not mistaken, failure to automatically parse information should prompt the user for input.
Actual behavior
I stepped through with the debugger and it fails in
ParsePackageAndGenerateInstallerNodes
becauseparseResult
isfalse
.Environment
The text was updated successfully, but these errors were encountered: