Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MisiteBao.Yakia version 0.1.0 #98400

Conversation

misitebao
Copy link
Contributor

@misitebao misitebao commented Mar 3, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@misitebao
Copy link
Contributor Author

@misitebao please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@misitebao
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 3, 2023
@microsoft-github-policy-service
Copy link
Contributor

misitebao,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@stephengillie
Copy link
Collaborator

stephengillie commented Mar 3, 2023

Hi @misitebao,

This program only seems to print a string:

Tool is under development, please wait...

Is this the program's intended function?

@misitebao
Copy link
Contributor Author

misitebao commented Mar 4, 2023

@stephengillie @microsoft-github-policy-service
Yakia is a CLI developed in Go. Because wingetcreate cannot correctly parse binary files built in Go language, I developed this console program in C# for testing. It is a placeholder for the time being and an announcement at the same time. Hope the PR can be approved.

By the way, wingetcreate cannot correctly parse the binary files built by Go and Rust(microsoft/winget-create#302). I checked the bills in this regard, but I didn't find a better way. Can the official solve this problem?

@stephengillie
Copy link
Collaborator

stephengillie commented Mar 6, 2023

By the way, wingetcreate cannot correctly parse the binary files built by Go and Rust(microsoft/winget-create#302). I checked the bills in this regard, but I didn't find a better way. Can the official solve this problem?

Please consider using our other manifest building tools, such as YamlCreate, and Komac which can be installed with: WinGet install RussellBanks.Komac.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Mar 6, 2023
@misitebao
Copy link
Contributor Author

@stephengillie
Thanks for your patient reply, I request to merge this PR.
Regarding the new package maker you mentioned, I will test it locally, thank you very much.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 37f1f13 into microsoft:master Mar 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 7, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@misitebao misitebao deleted the autogenerated/MisiteBao.Yakia/7636f436-468a-47c6-90f8-661476269574 branch March 7, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants