Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wingetcreate update based on GitHub release #497

Open
rursprung opened this issue Dec 28, 2023 · 0 comments
Open

wingetcreate update based on GitHub release #497

rursprung opened this issue Dec 28, 2023 · 0 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Milestone

Comments

@rursprung
Copy link

rursprung commented Dec 28, 2023

Description of the new feature / enhancement

it'd be great if it'd be possible to run wingetcreate update with a GH release URL where it'd then scrape all relevant information from there (extracting the version number, automatically scanning all assets for windows installers and picking all, grabbing the release notes (see also #103), and possibly more).

one option would be that the user passes the URL - e.g. wingetcreate update --release-url https://github.com/microsoft/winget-create/releases/tag/v1.5.7.0
the other would be to instead pass GH specific information - e.g. wingetcreate update --repo microsoft/winget-create --tag v1.5.7.0

this is maybe also related to #368 (though that was about the create use-case)

for reference: komac supports this acc. to their README.

Proposed technical implementation details

in either case of the suggested calling ways the wingetcreate update would internally probably then extract the necessary information using the GitHub REST API (docs for the releases API).

one issue with the version number (which is also why i proposed --tag above instead of re-using --version) is that the tag might not correspond 1:1 to the version number, e.g. v1.5.7.0 vs. 1.5.7.0 (though maybe a simple heuristic might be enough to cover >95% of all cases?).

@rursprung rursprung added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 28, 2023
microsoft-github-policy-service bot pushed a commit to microsoft/winget-pkgs that referenced this issue Jan 2, 2024
the manifest has been created using the following command:
```bash
wingetcreate update miller.miller -v 6.10.0 -u https://github.com/johnkerl/miller/releases/download/v6.10.0/miller-6.10.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.10.0/miller-6.10.0-windows-amd64.zip
```

the `ReleaseNotesUrl` has been manually added as `wingetcreate update`
does not yet support release notes (see also
microsoft/winget-create#497).
@ryfu-msft ryfu-msft added this to the v.Next-Create milestone Jan 11, 2024
rursprung added a commit to rursprung/winget-pkgs that referenced this issue Jan 26, 2024
the manifest has been created using the following command:
```bash
wingetcreate update miller.miller -v 6.11.0 -u https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-amd64.zip
```

the `ReleaseNotesUrl` has been manually added as `wingetcreate update`
does not yet support release notes (see also
microsoft/winget-create#497).
microsoft-github-policy-service bot pushed a commit to microsoft/winget-pkgs that referenced this issue Jan 26, 2024
the manifest has been created using the following command:
```bash
wingetcreate update miller.miller -v 6.11.0 -u https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-amd64.zip
```

the `ReleaseNotesUrl` has been manually added as `wingetcreate update`
does not yet support release notes (see also
microsoft/winget-create#497).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

2 participants