Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Miller.Miller to 6.11.0 #136590

Conversation

rursprung
Copy link
Contributor

@rursprung rursprung commented Jan 26, 2024

the manifest has been created using the following command:

wingetcreate update miller.miller -v 6.11.0 -u https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-amd64.zip

the ReleaseNotesUrl has been manually added as wingetcreate update does not yet support release notes (see also
microsoft/winget-create#497).

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

the manifest has been created using the following command:
```bash
wingetcreate update miller.miller -v 6.11.0 -u https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.11.0/miller-6.11.0-windows-amd64.zip
```

the `ReleaseNotesUrl` has been manually added as `wingetcreate update`
does not yet support release notes (see also
microsoft/winget-create#497).
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rursprung
Copy link
Contributor Author

@johnkerl: it'd be great if you could implement johnkerl/miller#1459, then this doesn't have to be done manually!

as per @stephengillie's comment here a validation error is to be expected and needs to be waived: #123507 (comment) (the same was also the case in the previous version: #132018 (comment))

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 26, 2024
@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Jan 26, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jan 26, 2024
@stephengillie stephengillie added Validation-Completed Validation passed Retry-1 flag to indicate retried and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Retry-1 flag to indicate retried Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 32d7cba into microsoft:master Jan 26, 2024
5 of 7 checks passed
@rursprung rursprung deleted the update-miller.miller-to-6.11.0 branch January 26, 2024 15:47
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants