Reset version specific fields after update #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Feature
|
windows-2022 does not have sdk version 18360 installed. You could potentially update all projects under the solution to target 22000 to solve the build failure(22000 is the target version of our AppInstaller, 17763 is target min version). |
Thanks for letting me know, I will make that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #229
Currently, WingetCreate preserves the values of version specific fields such as ReleaseDate, ReleaseNotes, and ReleaseUrl when updating manifests. The changes in this PR reset those values after each update so that newly-updated manifests do not get populated with outdated values.
Changes:
Tests:
Microsoft Reviewers: Open in CodeFlow