-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added .NET Core Runtime version 5.0.6.30021. (#12540)
- Loading branch information
1 parent
19d5eb8
commit d410836
Showing
3 changed files
with
60 additions
and
0 deletions.
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
manifests/m/Microsoft/dotnetRuntime/5.0.6.30021/Microsoft.dotnetRuntime.installer.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json | ||
| PackageIdentifier: Microsoft.dotnetRuntime | ||
| PackageVersion: 5.0.6.30021 | ||
| Installers: | ||
| - Architecture: x64 | ||
| InstallerUrl: https://download.visualstudio.microsoft.com/download/pr/6279dc90-f437-4481-82a5-73dd9f97da06/6519ef44735fd31115b9b1a81d6ff1e8/windowsdesktop-runtime-5.0.6-win-x64.exe | ||
| InstallerSha256: 795A3C1CA13717BAA09F2CB09024A4A64C79037E4FB5F286069B53FF08284311 | ||
| InstallerType: exe | ||
| Scope: machine | ||
| - Architecture: x86 | ||
| InstallerUrl: | | ||
| https://download.visualstudio.microsoft.com/download/pr/315854e8-6857-4d0d-b7e0-57761e3f7d12/b31193ac2c9f1674b66cf7a65c2521de/windowsdesktop-runtime-5.0.6-win-x86.exe | ||
| InstallerSha256: EF874FE436367347A1B9BEE8E60CD5D0E3C58056F78787A66F206F4FDC49825B | ||
| InstallerType: exe | ||
| Scope: machine | ||
| - Architecture: arm64 | ||
| InstallerUrl: | | ||
| https://download.visualstudio.microsoft.com/download/pr/63040d2c-e953-492f-ae93-7d93cc658e7b/1fce7e44a06c2d432fc0a492ca2b1a13/windowsdesktop-runtime-5.0.6-win-arm64.exe | ||
| InstallerSha256: 2B06BE5540B8E3A62B6A270146ED906D00570C0DF71F54C142E8B4F1A66FB5F3 | ||
| InstallerType: exe | ||
| Scope: machine | ||
| InstallerSwitches: | ||
| Silent: /quiet /norestart | ||
| SilentWithProgress: /passive | ||
| Custom: /install | ||
| ManifestType: installer | ||
| ManifestVersion: 1.0.0 | ||
|
|
25 changes: 25 additions & 0 deletions
25
manifests/m/Microsoft/dotnetRuntime/5.0.6.30021/Microsoft.dotnetRuntime.locale.en-US.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultlocale.1.0.0.schema.json | ||
| PackageIdentifier: Microsoft.dotnetRuntime | ||
| PackageVersion: 5.0.6.30021 | ||
| PackageLocale: en-US | ||
| LicenseUrl: https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default | ||
| Moniker: dotNETruntime | ||
| Tags: | ||
| - .NET | ||
| - .NET Core | ||
| - dotnet | ||
| - net | ||
| - C# | ||
| - csharp | ||
| - F# | ||
| - fsharp | ||
| - VB | ||
| - Visual Basic | ||
| PackageUrl: https://dotnet.microsoft.com/download/dotnet-core/current/runtime | ||
| Publisher: Microsoft | ||
| PackageName: .NET Core Runtime | ||
| License: Copyright (c) Microsoft Corporation. All rights reserved. | ||
| ShortDescription: .NET Core Runtime is required to run an to run existing .NET Core application. | ||
| ManifestType: defaultLocale | ||
| ManifestVersion: 1.0.0 | ||
|
|
7 changes: 7 additions & 0 deletions
7
manifests/m/Microsoft/dotnetRuntime/5.0.6.30021/Microsoft.dotnetRuntime.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.0.0.schema.json | ||
| PackageIdentifier: Microsoft.dotnetRuntime | ||
| PackageVersion: 5.0.6.30021 | ||
| DefaultLocale: en-US | ||
| ManifestType: version | ||
| ManifestVersion: 1.0.0 | ||
|
|
d410836There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17674 (comment)
@ItzLevvie @jedieaston @denelon
Do we have to split them into
Microsoft.dotnetRuntime.x64,Microsoft.dotnetRuntime.x86andMicrosoft.dotnetRuntime.arm64?d410836There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OfficialEsco I think we might. They install "side by side" so they behave like different packages. This might also add some complexity for dependencies 🤦♂️
d410836There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For dependencies, (I think) manifests should optionally be able to specify an architecture (and probably a scope, there's probably an app out there that won't work with a user level install of python or whatever) with a
PackageIdentifier. This will add a gigantic testing headache though since we'd want to make sure that wasn't a lie (since for 90% of apps you can't install both architectures at once). Most manifests should not use the architecture (or set it to neutral) because most apps aren't that picky.I really really want to resist splitting the manifest because this is only for one app (and we just got multiarch support working). I don't know what the implementation timeline is for the
winget install --archflag, but that would work for this scenario, right (since if you wanted multiple SDKs, you could just run the command multiple times). But I don't know if that's defined behavior or not, consideringwinget installby itself not checking if the app is installed before running the installer is considered unintentional at the moment.d410836There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedieaston, I think we might be able to inherit architecture and scope from the installer node. I'm just wondering about packages that have dependencies on things with different requirements.
Yeah, I'm not a big fan of multiple manifests either. We may need to pull microsoft/winget-cli#906 in sooner to support this.