Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade version #17674

Merged
18 commits merged into from
Jun 17, 2021
Merged

upgrade version #17674

18 commits merged into from
Jun 17, 2021

Conversation

Sharkboy-j
Copy link
Contributor

@Sharkboy-j Sharkboy-j commented Jun 16, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jun 16, 2021
@ghost
Copy link

ghost commented Jun 16, 2021

Hello @JeremiSharkboy,
The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 16, 2021
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. PullRequest-Error PR is Invalid labels Jun 16, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 16, 2021
@ghost
Copy link

ghost commented Jun 16, 2021

Hello @JeremiSharkboy,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 16, 2021
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Jun 16, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 16, 2021
@ghost
Copy link

ghost commented Jun 16, 2021

Hello @JeremiSharkboy,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 16, 2021
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 16, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 16, 2021
@ghost
Copy link

ghost commented Jun 16, 2021

Hello @JeremiSharkboy,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 16, 2021
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Jun 16, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 16, 2021
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this, even though I've .NET 3.5, .NET 4 & .NET 5 installed on my device:
image

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 17, 2021
@Sharkboy-j
Copy link
Contributor Author

This is strange. It may be necessary to install .NET Desktop Runtime 5.0.7 x86 or x64. Im not sure

@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 17, 2021
@ItzLevvie
Copy link
Contributor

ItzLevvie commented Jun 17, 2021

It works with the x86 one (I had x64 installed on my machine) but the version seems different from the one written in the manifest:
image

In the manifest: it's 0.9.7837.24720 and in the application it's 0.9.7838.20204

@Sharkboy-j
Copy link
Contributor Author

It works with the x86 one (I had x64 installed on my machine) but the version seems different from the one written in the manifest:
image

In the manifest: it's 0.9.7837.24720 and in the application it's 0.9.7838.20204

Thats correct. That is because of autoupdater integrated into app

@ItzLevvie
Copy link
Contributor

since the app works with the x86 runtime rather than the x64 one, could you perhaps make the message a bit more clearer as to which one the user should download?

@Sharkboy-j
Copy link
Contributor Author

image
if you are talking about this message. guess no. Because this is default message of .Net Runtime and i can't change it

@ghost ghost added Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed labels Jun 17, 2021
@ghost ghost merged commit 2291ec2 into microsoft:master Jun 17, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

Hello @msftbot[bot]!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants