Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSProject.OBSStudio version 27.2.1 #47583

Conversation

krystofkrticka
Copy link
Contributor

@krystofkrticka krystofkrticka commented Feb 21, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 21, 2022
@ghost
Copy link

ghost commented Feb 21, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Feb 21, 2022

@krystofkrticka,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

@ghost ghost removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Feb 22, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

OfficialEsco
OfficialEsco previously approved these changes Feb 22, 2022
Copy link
Contributor

@OfficialEsco OfficialEsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 22, 2022
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Feb 22, 2022
@ghost
Copy link

ghost commented Feb 22, 2022

Hello @krystofkrticka,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Feb 22, 2022
@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed Moderator-Approved One of the Moderators has reviewed and approved this PR labels Feb 22, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 22, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@OfficialEsco
Copy link
Contributor

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Feb 22, 2022
@ghost
Copy link

ghost commented Feb 22, 2022

Hello @krystofkrticka,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Feb 22, 2022
@OfficialEsco
Copy link
Contributor

AHH It added Tabs instead of spaces
Code_kG2oK60UkD

@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Feb 22, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 22, 2022
@krystofkrticka
Copy link
Contributor Author

It took me a while to find those tabs, that's probably my bad since I pasted that part of text from notepad++ which I used to prepare that part of release notes because github's webeditor is unable to add something to multiple lines when I hold alt and drag mouse between those lines.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 22, 2022
@ghost
Copy link

ghost commented Feb 22, 2022

Hello @krystofkrticka,
Validation has completed.

@ghost ghost merged commit 7a31493 into microsoft:master Feb 22, 2022
@krystofkrticka krystofkrticka deleted the autogenerated/OBSProject.OBSStudio/1eb45f31-cb1c-48d6-a0ae-4f8e22819ca1 branch February 22, 2022 10:48
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants