Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent button height with some languages in "Data and storage" #126

Closed
7 tasks done
lyfja opened this issue Jan 18, 2024 · 2 comments
Closed
7 tasks done

Inconsistent button height with some languages in "Data and storage" #126

lyfja opened this issue Jan 18, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@lyfja
Copy link
Contributor

lyfja commented Jan 18, 2024

Steps to reproduce

  1. Change app language to German (for example)
  2. Go to data and storage settings ("Daten und Speicher")
  3. Observe inconsistent button height for backup and restore

Expected behavior

Both buttons should be the same height

Actual behavior

One of the buttons is bigger than the other since it has more text in it (see screenshot)

Crash logs

No response

Mihon version

Beta r6454

Android version

Android 13

Device

Motorola Edge 40

Other details

Screenshot_20240118-084209

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.1.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@lyfja lyfja added the Bug Something isn't working label Jan 18, 2024
@MajorTanya
Copy link
Contributor

That'll be down to text wrapping I'm guessing, someone should look into that

@theolm
Copy link
Contributor

theolm commented Jan 23, 2024

I take this one. Should open a PR soon. ✌️

@theolm theolm mentioned this issue Jan 23, 2024
Merged
kaiserbh pushed a commit to kaiserbh/mihon that referenced this issue Feb 18, 2024
@theolm @jobobby04
Fix mihonapp#126: Inconsistent button height with some languages in "…
100f160 
…Data and storage" (mihonapp#202)

* replace the windowInsetsPadding for navigationBarsPadding + statusBarsPadding

* Fixing bug in the MultiChoiceSegmentedButtonRow

* Rollback file

(cherry picked from commit 1dd130d)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theolm @MajorTanya @lyfja