Fix #126: Inconsistent button height with some languages in "Data and storage" #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiserbh
pushed a commit
to kaiserbh/mihon
that referenced
this pull request
Feb 18, 2024
…Data and storage" (mihonapp#202) * replace the windowInsetsPadding for navigationBarsPadding + statusBarsPadding * Fixing bug in the MultiChoiceSegmentedButtonRow * Rollback file (cherry picked from commit 1dd130d)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes the #126
The
MultiChoiceSegmentedButtonRowwill have the Min height of its content, and theSegmentedButtonwill fill theMultiChoiceSegmentedButtonRowheight. This combination will make both buttons have the same size and support multiple lines.Images