node-notifier v6 release #285
Conversation
|
@jnielson94 Can you think of other major changes we should include in the scope for this release? |
|
So far as I'm aware the things to include are:
I think you've captured those in your description? We could check for updated versions of the other vendor apps? |
|
more updates? |
|
We are awaiting testing new snoreToast on Windows. @jnielson94 is currently out traveling and doesn't have access to test (nor have I right now). |
|
Is the test just for |
There was a problem hiding this comment.
@mikaelbr - I adjusted some documentation mainly to try and get this ready to merge in and release. In my testing I found that the exit codes for SnoreToast had changed and we were getting error codes that we didn't care to forward on. We'll probably need to adjust that handling if/when we want to add support for buttons/textboxes on there but it should work for now. I'm going to mark this approved, but I would appreciate if you'd glance at the documentation changes and make sure they sound about right.
This comment has been minimized.
This comment has been minimized.
|
@jnielson94 😵 Didn't catch that you had tested this out. Sorry about that! The docs look good. I'm merging this and publishing v6 right away. |
|
Released now! Thanks for all your work, @jnielson94 . |
Re-added this as a seperate work branch for the entire release, with the new timeout semantics, and updated dependencies.
Did this as a branch as there were some issues with previous releases, and having the master branch without the breaking changes for now is easier than to jump between versions and tags.
Should be merged when we have the scope of v6 right and all breaking changes are ready.
Scope