V2 - uses precise calculation for node.js, and separate implementation for the browser. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the string representation of the object to a buffer and then it uses the byteLength property to obtain the size of the buffer in bytes
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage ? 92.68%
=========================================
Files ? 2
Lines ? 41
Branches ? 0
=========================================
Hits ? 38
Misses ? 3
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
miktam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 uses different implementations for Node.js and browsers.
Node.js: the Buffer.from(objectToString) method to convert the object's string representation to a buffer, and then it uses the byteLength property to obtain the size of the buffer in bytes.
Browser: Iterates through a tree recursively and, depending on the element type, calculates byte size.