enhance: make delegator lock critical smaller (#36997)

issue: #36804 Signed-off-by: chyezh <[email protected]>
milvus-io · Oct 21, 2024 · ac178ee · ac178ee
1 parent 7033982
commit ac178ee
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/querynodev2/delegator/delegator_data.go b/internal/querynodev2/delegator/delegator_data.go
@@ -878,6 +878,9 @@ func (sd *shardDelegator) ReleaseSegments(ctx context.Context, req *querypb.Rele
 	case querypb.DataScope_Historical:
 		sealed = lo.Map(req.GetSegmentIDs(), convertSealed)
 	}
+	signal := sd.distribution.RemoveDistributions(sealed, growing)
+	// wait cleared signal
+	<-signal
 
 	if len(growing) > 0 {
 		sd.growingSegmentLock.Lock()
@@ -893,9 +896,6 @@ func (sd *shardDelegator) ReleaseSegments(ctx context.Context, req *querypb.Rele
 	})
 	sd.AddExcludedSegments(droppedInfos)
 
-	signal := sd.distribution.RemoveDistributions(sealed, growing)
-	// wait cleared signal
-	<-signal
 	if len(sealed) > 0 {
 		sd.pkOracle.Remove(
 			pkoracle.WithSegmentIDs(lo.Map(sealed, func(entry SegmentEntry, _ int) int64 { return entry.SegmentID })...),