Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make delegator lock critical smaller #36997

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Oct 18, 2024

issue: #36804

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.35%. Comparing base (8669153) to head (0d5be22).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36997      +/-   ##
==========================================
- Coverage   80.64%   72.35%   -8.30%     
==========================================
  Files        1310     1310              
  Lines      183578   183597      +19     
==========================================
- Hits       148054   132848   -15206     
- Misses      30393    45635   +15242     
+ Partials     5131     5114      -17     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator_data.go 85.54% <100.00%> (-0.92%) ⬇️

... and 244 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Oct 21, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ac178ee into milvus-io:master Oct 21, 2024
15 of 16 checks passed
@chyezh chyezh deleted the enhance_delegator_lock_critical branch October 21, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants