Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Nightly] Query with expression failed when output count #37274

Closed
1 task done
NicoYuan1986 opened this issue Oct 29, 2024 · 8 comments
Closed
1 task done

[Bug]: [Nightly] Query with expression failed when output count #37274

NicoYuan1986 opened this issue Oct 29, 2024 · 8 comments
Assignees
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@NicoYuan1986
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: b44ef82
- Deployment mode(standalone or cluster):cluster
- MQ type(rocksmq, pulsar or kafka):    kafka
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Query with expression failed when output count.

[pytest : test] [2024-10-28 20:43:28 - DEBUG - ci_test]: (api_request)  : [Collection.query] args: ['(float + 1) == 3 or float * 2 == 64 or float == 10**2', ['count(*)'], None, 180], kwargs: {} (api_request.py:62)
[pytest : test] [2024-10-28 20:43:29 - ERROR - pymilvus.decorators]: RPC error: [query], <MilvusException: (code=65535, message=fail to Query on QueryNode 9: worker(9) query failed: Assert "(value_proto.val_case() == planpb::GenericValue::kFloatVal)"  at /workspace/source/internal/core/src/query/PlanProto.cpp:152
[pytest : test] )>, <Time:{'RPC start': '2024-10-28 20:43:28.060369', 'RPC error': '2024-10-28 20:43:29.049176'}> (decorators.py:147)
[pytest : test] [2024-10-28 20:43:29 - ERROR - ci_test]: Traceback (most recent call last):
[pytest : test]   File "/milvus/tests/python_client/utils/api_request.py", line 32, in inner_wrapper
[pytest : test]     res = func(*args, **_kwargs)
[pytest : test]   File "/milvus/tests/python_client/utils/api_request.py", line 63, in api_request
[pytest : test]     return func(*arg, **kwargs)
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/orm/collection.py", line 1076, in query
[pytest : test]     return conn.query(
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/decorators.py", line 148, in handler
[pytest : test]     raise e from e
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/decorators.py", line 144, in handler
[pytest : test]     return func(*args, **kwargs)
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/decorators.py", line 183, in handler
[pytest : test]     return func(self, *args, **kwargs)
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/decorators.py", line 123, in handler
[pytest : test]     raise e from e
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/decorators.py", line 87, in handler
[pytest : test]     return func(*args, **kwargs)
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/client/grpc_handler.py", line 1536, in query
[pytest : test]     check_status(response.status)
[pytest : test]   File "/usr/local/lib/python3.8/site-packages/pymilvus/client/utils.py", line 63, in check_status
[pytest : test]     raise MilvusException(status.code, status.reason, status.error_code)
[pytest : test] pymilvus.exceptions.MilvusException: <MilvusException: (code=65535, message=fail to Query on QueryNode 9: worker(9) query failed: Assert "(value_proto.val_case() == planpb::GenericValue::kFloatVal)"  at /workspace/source/internal/core/src/query/PlanProto.cpp:152
[pytest : test] )>
[pytest : test]  (api_request.py:45)
[pytest : test] [2024-10-28 20:43:29 - ERROR - ci_test]: (api_response) : <MilvusException: (code=65535, message=fail to Query on QueryNode 9: worker(9) query failed: Assert "(value_proto.val_case() == planpb::GenericValue::kFloatVal)"  at /workspace/source/internal/core/src/query/PlanProto.cpp:152
[pytest : test] )> (api_request.py:46)

Expected Behavior

pass

Steps To Reproduce

No response

Milvus Log

  1. link: https://jenkins.milvus.io:18080/blue/organizations/jenkins/Milvus%20Nightly%20CI(new)/detail/2.4/66/pipeline/134
  2. log: artifacts-milvus-distributed-kafka-mdk-24-66-py-n-66-e2e-logs.tar.gz
  3. error case: test_count_expression_auto_field

Anything else?

No response

@NicoYuan1986 NicoYuan1986 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 29, 2024
@NicoYuan1986 NicoYuan1986 added this to the 2.4.14 milestone Oct 29, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 30, 2024
@yanliang567
Copy link
Contributor

/assign @MrPresent-Han
/unassign

@xiaofan-luan
Copy link
Collaborator

can you try float * 2 == 64.0 can work?
I'm assuming this is a expression need implicit conversion and we don't support

@yanliang567
Copy link
Contributor

can you try float * 2 == 64.0 can work? I'm assuming this is a expression need implicit conversion and we don't support

It works on master and before

@yanliang567
Copy link
Contributor

/assign @xiaocai2333

@xiaocai2333
Copy link
Contributor

It seems that converting variables to float was omitted when supporting expression templates.
I will fix it.

@MrPresent-Han
Copy link
Contributor

/unassign

sre-ci-robot pushed a commit that referenced this issue Nov 1, 2024
sre-ci-robot pushed a commit that referenced this issue Nov 2, 2024
sre-ci-robot pushed a commit that referenced this issue Nov 3, 2024
@xiaocai2333
Copy link
Contributor

It has been fixed, please verify.
/assign @NicoYuan1986
/unassign

@NicoYuan1986
Copy link
Contributor Author

fixed. master-20241106-8275e40f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants