Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5]Fix the bug where some expressions do not correctly parse the value #37343

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #37274

master pr: #37341

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (164ed80) to head (d9921a8).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/parser/planparserv2/parser_visitor.go 40.00% 1 Missing and 2 partials ⚠️
internal/parser/planparserv2/utils.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37343      +/-   ##
==========================================
- Coverage   83.05%   80.84%   -2.21%     
==========================================
  Files        1031     1321     +290     
  Lines      157666   183092   +25426     
==========================================
+ Hits       130943   148017   +17074     
- Misses      21518    29879    +8361     
+ Partials     5205     5196       -9     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.93% <ø> (∅)
Go 83.11% <76.92%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/parser/planparserv2/parser_visitor.go 86.03% <40.00%> (+0.07%) ⬆️
internal/parser/planparserv2/utils.go 84.36% <85.71%> (-0.26%) ⬇️

... and 315 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 1, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 1, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 1, 2024
@sre-ci-robot sre-ci-robot merged commit 116bf50 into milvus-io:2.5 Nov 1, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants