fix: Remove time tick delay metrics when nodes go offline #30833
Conversation
See also milvus-io#30832 This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode Also add unit tests for this case Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
@congqixia ut workflow job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi.Xia <[email protected]>
Signed-off-by: Congqi.Xia <[email protected]>
|
@congqixia E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30833 +/- ##
==========================================
+ Coverage 80.48% 80.71% +0.22%
==========================================
Files 964 964
Lines 137160 137276 +116
==========================================
+ Hits 110400 110802 +402
+ Misses 23036 22751 -285
+ Partials 3724 3723 -1
|
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
/lgtm |
yanliang567
added
ci-passed
manual-pass
…30833) See also milvus-io#30832 This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode Also add unit tests for this case --------- Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Congqi.Xia <[email protected]>
…ne (#30833) (#30879) Cherry-pick from master pr: #30833 See also #30832 This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode Also add unit tests for this case --------- --------- Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Congqi.Xia <[email protected]>
See also #30832
This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode
Also add unit tests for this case