Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove time tick delay metrics when nodes go offline #30833

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix: Remove time tick delay metrics when nodes go offline #30833

merged 3 commits into from
Feb 28, 2024

Commits on Feb 26, 2024

  1. fix: Remove time tick delay metrics when nodes go offline 

    See also milvus-io#30832

This PR removes time tick delay metrics when rootcoord GetMetrics
response does not have previously existed querynode/datanode

Also add unit tests for this case

Signed-off-by: Congqi Xia <[email protected]>
    @congqixia
    congqixia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0060668 View commit details
    Browse the repository at this point in the history

  2. Reset metrics before unittest 

    Signed-off-by: Congqi.Xia <[email protected]>
    @congqixia
    congqixia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5787153 View commit details
    Browse the repository at this point in the history

  3. Fix lint issue 

    Signed-off-by: Congqi.Xia <[email protected]>
    @congqixia
    congqixia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2f3e148 View commit details
    Browse the repository at this point in the history