Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: enable stream writer in compactions #32612

Merged
merged 3 commits into from
May 17, 2024
Merged

enhance: enable stream writer in compactions #32612

merged 3 commits into from
May 17, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Apr 25, 2024

See #31679

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@tedxu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@tedxu
Copy link
Contributor Author

tedxu commented Apr 25, 2024 •
edited
Loading

In this PR, the stream writer (introduced in #31537) is integrated into the compactor. By removing the intermediate serialized data structure, the memory copy is greatly reduced. The benchmark (BenchmarkCompaction) showed a positive result:

Before:

BenchmarkCompaction-8         57           22303957 ns/op        251523736 B/op      8563 allocs/op
PASS

Enhanced:

BenchmarkCompaction-8         313           3407496 ns/op         1325833 B/op       6982 allocs/op
PASS

@tedxu tedxu changed the title Enhance: enable stream writer in compactions enhance: enable stream writer in compactions Apr 25, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Apr 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu tedxu force-pushed the enhance/enable_stream_writer branch from c235663 to d4a8350 Compare April 25, 2024 10:08
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Apr 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.22078% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (dd9919a) to head (3649770).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32612      +/-   ##
==========================================
- Coverage   82.14%   82.11%   -0.04%     
==========================================
  Files        1006     1006              
  Lines      128194   128197       +3     
==========================================
- Hits       105306   105266      -40     
- Misses      18919    18954      +35     
- Partials     3969     3977       +8
Files Coverage Δ
internal/datanode/io/binlog_io.go 100.00% <ø> (ø)
internal/datanode/binlog_io.go 85.00% <66.66%> (-6.87%) ⬇️
internal/storage/serde.go 88.96% <88.23%> (+1.72%) ⬆️
internal/datanode/compactor.go 90.08% <77.77%> (-0.26%) ⬇️

... and 34 files with indirect coverage changes

@tedxu
Copy link
Contributor Author

tedxu commented Apr 28, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 28, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor

/lgtm

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 29, 2024
@tedxu tedxu force-pushed the enhance/enable_stream_writer branch from e7aa0f7 to 3649770 Compare May 16, 2024 00:04
@sre-ci-robot sre-ci-robot removed the lgtm label May 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented May 16, 2024

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a9c7ce7 into milvus-io:master May 17, 2024
14 of 15 checks passed
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jun 24, 2024
@XuanYang-cn
enhance: [cherry-pick] Move compactor into sub package
d5c2dbb 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (milvus-io#32198)
- fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554)
- enhance: Add deltaRowCount in l0 compaction (milvus-io#33997)
- enhance: enable stream writer in compactions (milvus-io#32612)

See also: milvus-io#32451, milvus-io#33547, milvus-io#33998, milvus-io#31679
pr: milvus-io#32198, milvus-io#33554, milvus-io#33997, milvus-io#32612

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this pull request Jun 24, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jun 25, 2024
@XuanYang-cn @tedxu
enhance: [cherry-pick] Move compactor into sub package (#34098)
a33b686 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (#32198)
- fix: Fix l0 compactor may cause DN from OOM (#33554)
- enhance: Add deltaRowCount in l0 compaction (#33997)
- enhance: enable stream writer in compactions (#32612)
- fix: turn on compression on stream writers (#34067)
- fix: adding blob memory size in binlog serde (#33324)

See also: #32451, #33547, #33998, #31679
pr: #32198, #33554, #33997, #32612

---------

Signed-off-by: yangxuan <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
Co-authored-by: Ted Xu <[email protected]>
@tedxu tedxu mentioned this pull request Oct 29, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tedxu @XuanYang-cn @congqixia @sre-ci-robot @yanliang567