feat: adding binlog streaming writer #31537
Conversation
mergify
bot
added
dco-passed
|
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
tedxu
force-pushed
the
enhance/serialize_writer
branch
from
cc76640
to
7c28206
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31537 +/- ##
==========================================
+ Coverage 81.57% 81.68% +0.11%
==========================================
Files 989 990 +1
Lines 121653 122004 +351
==========================================
+ Hits 99234 99664 +430
+ Misses 18607 18512 -95
- Partials 3812 3828 +16
|
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
tedxu
force-pushed
the
enhance/serialize_writer
branch
from
cc1989e
to
ac2185c
Compare
mergify
bot
added
ci-passed
and removed
do-not-merge/missing-related-issue
ci-passed
labels
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
| if err := bsw.writeBinlogHeaders(&b); err != nil { | ||
| return nil, err | ||
| } | ||
| if _, err := b.Write(bsw.buf.Bytes()); err != nil { |
There was a problem hiding this comment.
According to the doc of buffer.Writer, err will always be nil and might be panic with ErrTooLarge. Please remove the err check here, might need to capture panic here.
There was a problem hiding this comment.
Thanks for the comment!
Well, the redundant error check may not be an issue. As for the ErrTooLarge panic, I guess we could ignore it as well, since it is thrown only if the writing length reaches max int.
|
/lgtm |
internal/storage/serde.go
Outdated
|
|
||
| // selectiveRecord is a Record that only contains a single field, reusing existing Record. | ||
| type selectiveRecord struct { | ||
| Record |
There was a problem hiding this comment.
this embeded Record is not used and duplicated with the r below causing extra interface usage for each entry
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
tedxu
force-pushed
the
enhance/serialize_writer
branch
from
2e7c693
to
5c0e0c8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See #31679