fix: Fill stats log id and check validity #33477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigsheeper <[email protected]>
mergify
bot
added
dco-passed
This was referenced May 30, 2024
|
/lgtm |
|
/lgtm |
Signed-off-by: bigsheeper <[email protected]>
sre-ci-robot
added
size/L
jaime0815
pushed a commit
that referenced
this pull request
May 30, 2024
1. Fill log ID of stats log from import 2. Add a check to validate the log ID before writing to meta issue: #33476 pr: #33477 --------- Signed-off-by: bigsheeper <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33477 +/- ##
==========================================
+ Coverage 81.95% 82.03% +0.08%
==========================================
Files 1014 1006 -8
Lines 129999 130238 +239
==========================================
+ Hits 106544 106845 +301
+ Misses 19469 19421 -48
+ Partials 3986 3972 -14
|
Signed-off-by: bigsheeper <[email protected]>
|
rerun ut |
sre-ci-robot
pushed a commit
that referenced
this pull request
May 31, 2024
1. Fill log ID of stats log from import 2. Add a check to validate the log ID before writing to meta issue: #33476 pr: #33477 --------- Signed-off-by: bigsheeper <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
1. Fill log ID of stats log from import 2. Add a check to validate the log ID before writing to meta issue: milvus-io#33476 --------- Signed-off-by: bigsheeper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #33476