Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fill stats log id and check validity (#33477) #33478

Merged
merged 4 commits into from
May 31, 2024

Conversation

bigsheeper
Copy link
Contributor

  1. Fill log ID of stats log from import
  2. Add a check to validate the log ID before writing to meta

issue: #33476

pr: #33477

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 30, 2024
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 82.20%. Comparing base (38e5e33) to head (3e2288a).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33478      +/-   ##
==========================================
+ Coverage   82.19%   82.20%   +0.01%     
==========================================
  Files         997      997              
  Lines      128594   128632      +38     
==========================================
+ Hits       105696   105742      +46     
+ Misses      18926    18917       -9     
- Partials     3972     3973       +1     
Files Coverage Δ
internal/datacoord/import_scheduler.go 69.33% <100.00%> (ø)
internal/metastore/kv/binlog/binlog.go 73.07% <100.00%> (-1.24%) ⬇️
internal/metastore/kv/datacoord/util.go 60.62% <100.00%> (+5.59%) ⬆️
tests/integration/meta_watcher.go 75.26% <64.70%> (-6.70%) ⬇️

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 30, 2024
@czs007
Copy link
Collaborator

czs007 commented May 31, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 31, 2024
@sre-ci-robot sre-ci-robot merged commit 8ff5d27 into milvus-io:2.4 May 31, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants